>
> I just thought I would mention (in case you are still interested in
> putting the code into FriCAS) that I have fixed the bugs that I know
> about in file computation.spad.pamphlet at:
> https://github.com/martinbaker/multivector/
>
> In this pamphlet are implementations of various mathematical
> structures related to computation. such as:
> * lambda.spad
> * ski.spad
> * ILogic.spad
>
Some remarks:
- currently the code may fail to build due to use of non-ASCII
characters (this happens for example on my machine when I
use my normal setup). Basically speaking any non-ASCII character
(even in comments!) may cause build failure (unfortunatly, Lisp
treats unrecognised characters as errors). This is critical
problem as we have no control over setup of build machine.
- I see that you encode things using strings and integers. In
FriCAS better coding style is to use symbols. Basically,
use integers when you care that they are integers, that is
you perform arithmetic or use them as array indices. If you
just depend on having some distinct object and use only
comparisons (which seem to be the case), then symbols
are better. Similaray, use strings when you need to create
new ones, but if you have small number of "magic" strings,
then using symbols is better.
If you really need a bunch of magic integers, then use macros
to give them names:
my_magic_integer1 ==> 1::NNI
my_magic_integer2 ==> 2::NNI
- You implement a bunch of "expression like" domains. Have you checked
if existing domains have needed functionality? One obvious alternative
is to base you implementation on Kernel. Another is to use
SEexpression as representaion.
- Meaning of your '=' for intuitionistic logic is not clear. My impression
is that for quantifier-free intuitionistic formulas equivalence is
decidable, so that may be more natural choice. Releated to this I think
that there are more generally valid simplifications for intuitionistic
logic and the one you use seem fairly incomplete.
--
Waldek Hebisch
[email protected]
--
You received this message because you are subscribed to the Google Groups
"FriCAS - computer algebra system" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/fricas-devel?hl=en.
