Hi,
I now could remove all the blacklisted domains in the aldor-interface.
https://github.com/hemmecke/fricas/tree/fix-blacklisted-domains
In fact, aldor helped to discover a bug in the two spad files, that
actually the SPAD compiler should have refused to compile.
See explanation in the commit message... (attaced at the end of this mail)
https://github.com/hemmecke/fricas/commit/e68b728e0a5d7491e07f4a45db82e5cf2acf02cd
Although I personally don't like a type that involves #vl, a proper fix
would involve a change in the inferface of
DistributedMultivariatePolynomial. That seems to be too involved for the
moment, and maybe isn't wanted by other people.
I would like to make 3 commits as given below. I only have a ChangeLog
entry in the last commit, but I hope it's OK that way.
May I commit?
Ralf
=============================================================
commit 303577fa7632cfe6fc9f14d54ce5611e50043e14 (HEAD,
origin/fix-blacklisted-do
Author: Ralf Hemmecke <[email protected]>
Date: Sat Dec 31 17:25:22 2011 +0100
forget about blacklisted domains
ChangeLog | 6 ++++++
src/aldor/Makefile.in | 9 ---------
2 files changed, 6 insertions(+), 9 deletions(-)
commit e68b728e0a5d7491e07f4a45db82e5cf2acf02cd
Author: Ralf Hemmecke <[email protected]>
Date: Sun Feb 5 23:57:54 2012 +0100
fix: remove wrong parameter nv
IdealDecompositionPackage and QuasiAlgebraicSet2 used to require two
parameters where the first parameter was a list of variables and the
second parameter was supposed to be the length of this list.
This additional parameter for the list length was seemingly necessary
because of a weakness of the compiler. It no longer is.
In fact, that parameter was wrong conceptually and compilation should
have been rejected by the SPAD compiler. Formerly we had
F ==> Fraction Integer
Var ==> OrderedVariableList vl
Expon ==> DirectProduct(nv,NNI)
Dpoly ==> DistributedMultivariatePolynomial(vl,F)
QALG ==> QuasiAlgebraicSet(F, Var, Expon, Dpoly)
The 4 parameter of QuasiAlgebraicSet is required to be of type
PolynomialCategory(F,Expon,Var). However, the type of
DistributedMultivariatePolynomial(vl,F) is
PolynomialCategory(F,DirectProduct(#vl,NonNegativeInteger),
OrderedVariableList(vl)) with
reorder: (%,List Integer) -> %
This was a mismatch in the third parameter, namely the provided
DirectProduct(nv,NNI) vs. the expected
DirectProduct(#vl,NonNegativeInteger)
src/algebra/idecomp.spad.pamphlet | 6 ++----
src/algebra/qalgset.spad.pamphlet | 7 +++----
2 files changed, 5 insertions(+), 8 deletions(-)
commit 9449d68bfd108e70d85378c5d5c3d833f802d8d2
Author: Ralf Hemmecke <[email protected]>
Date: Sun Feb 5 21:51:28 2012 +0100
fix definition of RationalNumber
src/algebra/random.spad.pamphlet | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
You received this message because you are subscribed to the Google Groups "FriCAS -
computer algebra system" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/fricas-devel?hl=en.
