Hello Raoul,

Thanks for your pull request and having an eye on the open-axiom tree.
I had to change your commit a little and added a ChangeLog entry.

https://github.com/hemmecke/fricas/commit/140fc7b3fbe1801469c5dc111fe0932a3c926329

In particular, I did not like this line.
https://github.com/raoulb/fricas/commit/92368df3327c436fd2138c35dc7fd0ead49536b9#L0L91
because it was indented too much.

Furthermore, the special implementation of opposite? appeared under
OrderedAbelianGroup, while I have moved it to AbelianGroup.

I'm not sure, however, whether we really want to take over the lines
https://github.com/hemmecke/fricas/commit/140fc7b3fbe1801469c5dc111fe0932a3c926329#L2L232
into integer.spad.pamphlet. They do not hurt, but they are redundant,
since the implementation is inherited from the category defaults.
Waldek?

Ralf

PS: There is still something wrong since I get the error

   >> System error:
   Couldn't load
"/home/hemmecke/g/fricas-bisect/b/target/x86_64-unknown-linux/algebra/RNG-.fasl":
file does not exist.

(1) -> Stage 3 object copy
cp: cannot stat `DFLOAT.NRLIB/DFLOAT.fasl': No such file or directory
make[3]: *** [stamp-oboo3] Error 1

during a parallel compilation. Probably a new dependency in an early stage.

-- 
You received this message because you are subscribed to the Google Groups 
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/fricas-devel?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to