Ralf Hemmecke wrote:
>
> Looking a bit into the issue, it seemed to me that there was a forgotten
> comparison of the arguments part that come out from decode_diff (see
> patch below).
>
> =================================================================
> diff --git a/src/algebra/fspace.spad.pamphlet
> b/src/algebra/fspace.spad.pamphlet
> index 45ed9d5..35ecc43 100644
> --- a/src/algebra/fspace.spad.pamphlet
> +++ b/src/algebra/fspace.spad.pamphlet
> @@ -963,6 +963,7 @@ FunctionSpace(R : Comparable) : Category ==
> Definition where
> r1 := decode_diff(a1)
> r2 := decode_diff(a2)
> not(operator(r1.orig_k) = operator(r2.orig_k)) => false
> + not(r1.arg = r2.arg) => false
> not(r1.sub =$List(Integer) r2.sub) => false
> od : List K := [retract(dk)@K for dk in r1.dummies]
> ok1 : % := (r1.orig_k)::%
Yes, you are right, we should compare arguments. I would put
comparison of arguments after comparison of subscripts
(the 'not(r1.sub =$List(Integer) r2.sub) => false' line), because
comparing arguments potentially is most expensive, so we want
to avoid it if the other tests fail.
--
Waldek Hebisch
[email protected]
--
You received this message because you are subscribed to the Google Groups
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/fricas-devel.
For more options, visit https://groups.google.com/groups/opt_out.
