On 05/31/2014 07:14 PM, Waldek Hebisch wrote:
>> Can this %series go away?

> I am not a fan of such names.

That's what I wanted to know.

> But changing name one have to avoid name clashes.  This record is
> used in quite large area of code and I am not sure if there exist
> good names which do not collide we other names used in the code. 

We don't have sooo many cases (see below)

That make for %series, %problem, %expansion %term, %coef, %expon,
%expTerms, %type, %zeroTerms, %list, %order, %ord, %str, %sin, %cos,
%sinh, %cosh.

Excepf for %term and we could replace % by z.

for v in series problem expansion term coef expon expTerms type
zeroTerms list order ord str sin cos sinh cosh; do grep -nHR "z$v" *; done
src/interp/sfsfun.boot:251:        zterm := z
src/interp/sfsfun.boot:258:                zterm := zterm*zsquaredinv
src/interp/sfsfun.boot:259:                sum := sum + el*zterm
src/algebra/u32vec.spad:500:            zcoeffs := new(zdeg0, 0)$PA
src/algebra/u32vec.spad:501:            inner_mul(xcoeffs, ycoeffs,
zcoeffs, xdeg, ydeg, zdeg, p)
src/algebra/u32vec.spad:502:            zcoeffs

That shouldn't lead to any name clashes and can be done automatically.

Ralf


$ grep -R '[,(] *%[a-zA-Z0-9 ]*:' *
src/input/elemnum.input:testLibraryError("atan(%i::Complex Float)")
src/input/elemnum.input:testLibraryError("atan(%i::Complex DFLOAT)")
src/input/r21bugs.input:map(complexForm, %::List EXPR COMPLEX INT)
src/input/tutchap67.input:map(x+->eval(x,[m=1,ux=20,uy=10,g=9.8]),%::Vector
Expression Integer)
src/input/exprpoly.input:b - (% :: EXPR INT)
src/input/exprpoly.input:b - (% :: EXPR INT)
src/doc/htex/ug12.htex:  Join(Rng,Monoid,LeftModule(%: Rng)) with
src/share/doc/msgs/s2-us.msgs: Perhaps you can try substituting
something like %ceon %b ( %1 :: PI )
src/share/doc/msgs/s2-us.msgs: %d %l or %l %b ( %1 ::  NNI ) %d %ceoff
into your expression for %1b .
src/algebra/fs2ups.spad:  Result  ==> Union(%series : UPS, %problem :
Problem)
src/algebra/fs2ups.spad:  Result  ==> Union(%series : UPS, %problem :
Problem)
src/algebra/fs2expxp.spad:  Result   ==> Union(%series : UPXS, %problem
: Problem)
src/algebra/fs2expxp.spad:  XResult  ==> Union(%expansion : XXP,
%problem : Problem)
src/algebra/catdef.spad:--CommutativeRing(): Category == Join(Ring,
BiModule(%: Ring, %: Ring)) with
src/algebra/catdef.spad:--  Join(CommutativeRing, Algebra(%:
CommutativeRing), EntireRing) with
src/algebra/catdef.spad:--Ring(): Category == Join(Rng, Monoid,
LeftModule(%: Rng)) with
src/algebra/expexpan.spad:  Term    ==> Record(%coef : UPXS, %expon :
EXPUPXS, %expTerms : List PxRec)
src/algebra/expexpan.spad:  TypedTerm ==> Record(%term : Term, %type :
String)
src/algebra/expexpan.spad:  TRec    ==> Record(%zeroTerms : List Term, _
src/algebra/expexpan.spad:    filterByOrder : (L Term, (RN, RN) -> B) ->
Record(%list : L Term, %order : RN)
src/algebra/expexpan.spad:    iDominantTerm : L Term ->
Union(Record(%term:Term,%type:String),"failed")
src/algebra/expexpan.spad:      termInfo := tInfo :: Record(%term :
Term, %type : String)
src/algebra/expexpan.spad:  Term     ==> Record(%coef : UPXS, %expon :
EXPUPXS, %expTerms : List PxRec)
src/algebra/expexpan.spad:  TypedTerm ==> Record(%term : Term, %type :
String)
src/algebra/sups.spad:    Rep := Record(%ord : REF, %str : Stream Term)
src/algebra/sups.spad:      iSincos : (%, Coef, Coef, I) -> Record(%sin
: %, %cos : %)
src/algebra/sups.spad:      sincos : % -> Record(%sin : %, %cos : %)
src/algebra/sups.spad:      sinhcosh : % -> Record(%sinh : %, %cosh : %)
src/algebra/mrv_limit.spad:      -- UPS_Result  ==> Union(%series:
ULS_X, %problem: Problem)

-- 
You received this message because you are subscribed to the Google Groups 
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/fricas-devel.
For more options, visit https://groups.google.com/d/optout.

Reply via email to