On 09/28/2014 05:12 PM, Waldek Hebisch wrote: >> I'd appreciate to add Rioboo's code with two commits (and with the >> URLs that I've put at the top of the file). First commit would be >> the original code as is and the second commit with all the >> modifications to make it run in FriCAS and beautify it.
> I am against commiting non-working version. As you wish. But then such a commit https://github.com/hemmecke/fricas/commit/3cb96bb40dc9ee1cedac165a37fd8d7a8cd22dc3 - f : ((RUP,RUP) -> Boolean) := (degree(#1) <= degree(#2)) + f : ((RUP,RUP) -> Boolean) := (x, y) +-> (degree(x) <= degree(y)) would be enough to make Rioboo's code compiling in FriCAS. > Such versions may cause trouble when one searches for wrong commit by > bisection. I agree, that we shouldn't have non-compiling code, although one can tell git-bisect to ignore non-compiling versions. I'd still prefer the references to Rioboo's original code and to his statement about the license (which I've added here: https://github.com/hemmecke/fricas/commit/d2e1cd4a0bf15e1550a6e9b3d11901b9ebef3473 http://lists.gnu.org/archive/html/axiom-developer/2005-10/msg00125.html http://lists.nongnu.org/archive/html/axiom-developer/2014-09/msg00028.html http://rioboo.free.fr/CadPub/ ) Ralf -- You received this message because you are subscribed to the Google Groups "FriCAS - computer algebra system" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/fricas-devel. For more options, visit https://groups.google.com/d/optout.
