> 
> )savesystem is fixed in Axiom by this commit
> https://github.com/daly/axiom/commit/abbb38c1a4395448f8d769dff02a4e17c4308bf8
> 
> Now )savesystem can preserve variables and functions,
> I think it's useful and should be added to FriCAS.
> I ported this change to FriCAS as following patch:
>

Thank for the patch.  ATM I see two problems:

- saving images is not supported by ECL, so we need to
  disable this for ECL,
- the code from the patch will skip part of initialization
  if initialization is re-run.  This looks wrong: one
  may explicitely call initialization function to restart
  the system and also during build we dump running system
  and expect it to come in "fresh" state.

The second problem looks easy to fix:
 
>  show l ==
> diff --git a/src/interp/i-toplev.boot b/src/interp/i-toplev.boot
> index 18f79ca..e7d1b7a 100644
> --- a/src/interp/i-toplev.boot
> +++ b/src/interp/i-toplev.boot
> @@ -87,11 +87,13 @@ interpsysInitialization() ==
> 
>  interpsys_restart() ==
>    $IOindex := 1
> -  $InteractiveFrame := makeInitialModemapFrame()
>    loadExposureGroupData()
>    statisticsInitialization()
> -  initHist()
> -  initializeInterpreterFrameRing()
> +  if not $ThisIsARunningSystem then
> +    $InteractiveFrame := makeInitialModemapFrame()
> +    initHist()
> +    initializeInterpreterFrameRing()
> +  $ThisIsARunningSystem := true
                              ^^^^

I think this should be 'false' so that initialization is redone
when needed.  Of course, given that we should have better
name for the variable...

-- 
                              Waldek Hebisch
[email protected] 

-- 
You received this message because you are subscribed to the Google Groups 
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/fricas-devel.
For more options, visit https://groups.google.com/d/optout.

Reply via email to