Abhinav Baid wrote:
>
> On 9/10/15, Ralf Hemmecke <[email protected]> wrote:
> >
> > 'rest(v, ii)' unnecessarily introduces linear time.
> >
> I've changed it to the tails form as suggested by Waldek and also
> removed the '=>' used.
>
> > As for the variable 'semi'. It is only important if 'option="semireg".
> > Feels to me like you are wasting time computing 'semi' it if this option
> > is not set.
> >
> > Furthermore, in case of "semireg", you use 'semi' as a Table to have
> > direct access to semi.i or semi.j. But do your really need it? The
> > current implementation of Table falls back to AssociationList for your
> > Key type and that has linear time access. Maybe better avoid Table.
> >
> I've changed it to a OneDimensionalArray. [1]
>
> > In the end you remove all the unsafe factors from v. I've now not looked
> > at the paper, but it looks a bit suspicious that your code can put i
> > several times into the 'unsafe' list. That means at the same time that
> > the factor i is added to semi(j) for two different j's.
> >
> > Furthermore, it can happen that one j puts i into the 'unsafe' list and
> > the same i (although now "unsafe") puts a later j to the 'unsafe' list.
> > Is that behaviour OK?
> Yes, the above points are non-issues.
>
> [1]
> https://github.com/fandango-/fricas/commit/429c736a867205ecab54cb17026d8384a09850ec
Looks OK.
--
Waldek Hebisch
[email protected]
--
You received this message because you are subscribed to the Google Groups
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/fricas-devel.
For more options, visit https://groups.google.com/d/optout.
