> IIUC you want to add 'totalDegree' as a conditional export > from FreeModuleCategory and remove GeneralDistributedMultivariatePolynomial > This looks hacky to me: I do not see good mathematical sense > of this for FreeModuleCategory.
Hmmm. OK, you are right from the mathematical point of view. I should rethink of why I wanted it there. > Concerning problems with compilation: I would like to look > more carefully at what happens, but unfortunately, I had > (and still have) a lot of distractions so did not have > time to do this. OK, even when I move totalDegree to some other place, it would be nice to know why I had problems in the first place. > BTW: It makes sense to reorganize IndexedDirectProductCategory, > FreeModuleCategory, AbelianMonoidRing, FiniteAbelianMonoidRing. > One possiblity is to inherit FiniteAbelianMonoidRing also > from FreeModuleCategory Yes, we should carefully craft an appropriate hierarchy and remove any unwanted stuff. I quickly looked over the code and it seems Franz Lehner was involved in the IndexedDirectProduct* stuff. I hope I will also comment here. Since you spoke of a FiniteSupport category. Yes, I think that would be a good idea, but before introducing it, let's look over what we have now. According to documentation of IndexedDirectProductCategory, elements of the respective domains must have finite support. In contrast, AbelianMonoidRing explicitly states that its elements need not have finite support, while MonoidRing claims finite support. Given that (https://en.wikipedia.org/wiki/Monoid_ring) a monoid ring is defined with element of finite support. I tend to change to that meaning in our Algebra library. Otherwise we confuse mathematicians. A monoid ring is more like a direct sum over the index set while I would more naturally think of elements of a direct product indexed by some set having infinite support. I'd rather think we should have IndexedDirectProductCategory with possibly infinite support, MonoidRing and AbelianMonoidRing with finite support. That means that FiniteMonoidRing should go away. I haven't yet checked the aldor library, but I'll try to come up with some suggestion in the next days. Opinions? Ralf -- You received this message because you are subscribed to the Google Groups "FriCAS - computer algebra system" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/fricas-devel. For more options, visit https://groups.google.com/d/optout.
