oldk1331 wrote: > https://github.com/oldk1331/fricas/commit/391150ca162af518b8adce509997757fbaacba54.patch > > this patch fixes code related to BasicType: > > = (equality operator) and functions that only relies on = requires > S has BasicType, not SetCategory.
Actually, we can compute equality only for finite aggregates. So BasicType is declared correctly. The SetCategory declaration is too optimistic. > In BinaryRecursiveAggregate, "has SetAggregate(S)" is totally wrong. > > https://github.com/oldk1331/fricas/commit/24c636cd53e173cd550d4daa96c49045b89e22a9.patch At first glance I can not see if it is wrong or not: it depends on intent of original writer. I suspect that the intention was to use this code only for sparse sets. -- Waldek Hebisch -- You received this message because you are subscribed to the Google Groups "FriCAS - computer algebra system" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/fricas-devel. For more options, visit https://groups.google.com/d/optout.
