I think I have addressed the issues that Waldek raised.

I have merged in the spelling correction from trunk.
I have also tried to match the style issues that Waldek uses (such as removing 'date last changed' from header) although I have not seen these style standards documented so I'm not really sure if this is a requirement.
I have removed the whitespace either side of colon in urls.

I have changed "=" in groupPresentation. This now implements equality except that it should not be sensitive to the index value used to represent generators. Also it is not sensitive to some reordering of relations.

I have changed 'genName' as you suggested to avoid dependency on ASCII codes and to fix bug.

I have changed removeGen2 as you suggested to match standard idioms.

If anyone would like to try the code it is in usual place:

https://github.com/martinbaker/multivector/blob/master/logic.spad
https://github.com/martinbaker/multivector/blob/master/graph.spad
https://github.com/martinbaker/multivector/blob/master/groupPresentation.spad
https://github.com/martinbaker/multivector/blob/master/algebraictopology.spad

Then compile as follows:

)boot $createLocalLibDb:=false
)co logic
)co graph
)co groupPresentation
)boot $bootStrapMode := true
)co algebraictopology
)boot $bootStrapMode := false
)co algebraictopology

--
You received this message because you are subscribed to the Google Groups "FriCAS - 
computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/fricas-devel.
For more options, visit https://groups.google.com/d/optout.

Reply via email to