>
> https://github.com/oldk1332/fricas/commit/70fc6d890b3aa28a6dbe80919eb5f9c208bd9015.patch
>
> change UP(x,R) to UP in sturm.spad
<snip>
> I break up these commits for easier review, feel free to
> squash them into one or two commits.
Just few comments:
- patches should build and pass tests. I do someting like:
../source_tree/configure
make -j 7 > mlogg 2>&1 && make all-input > tst_logg 2>&1
then use 'norm-out' script to compare test output from
new build to the older one. All differences should be
insignificant or intended. For file using "new" test
framework (a bit more than 30) it is enough just look
at summaries: there should be no unexpected failures
(expected failures means known bugs). For other files
one needs to compare output (the 'norm-out' script
runs diff is such way that some systematic but
insignificant differences are ignored). If you
use the same Lisp on the same machine than usually
'norm-out' will just print list of file names, meaning
that there are not differences.
I also compare documentation pages, just using diff
on 'target/xxxx/share/hypertex/pages' subdirectories
of two build trees. Differences in 'ht.db' should be
ignored. Other should be intended.
I am writing this because the patches did not build
(due to use of a variable, while the patch removed
initialization of the variable). After fixing
build problem patches failed tests. Please
make sure that patches build and pass tests.
- I think you are overdoing splitting patches in
small parts. I can handle few hundreds line
patch with no problem. In case of overlapped
patches like 'sturm' series there were a lot
of lines changes by multiple patches, so splitting
here meant that I had more work than with
single patch. Splitting helps in case of
bigger patches (thousends of lines) or in
especially tricky cases. Also unrelated things
should be split (but Sturm changes were really
a single logical change).
--
Waldek Hebisch
--
You received this message because you are subscribed to the Google Groups
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/fricas-devel.
For more options, visit https://groups.google.com/d/optout.
