I fixed '=' and 'node?' for URAGG, now they
just like BinaryRecursiveAggregate.

No tests fail:

https://travis-ci.org/oldk1331/fricas/builds/221243638

https://github.com/oldk1331/fricas/commit/1e6aa191814dfeec8b277e147f04d2f5327c2cb1.patch

or:

--- a/src/algebra/aggcat.spad
+++ b/src/algebra/aggcat.spad
@@ -1485,8 +1485,8 @@
           n > (m := #x) => error "index out of range"
           copy rest(x, (m - n)::NonNegativeInteger)

-  if S has SetCategory then
-      x = y ==
+      if S has BasicType then
+        x = y ==
           eq?(x, y) => true
           for k in 0.. while not empty? x and not empty? y repeat
               k = cycleMax and cyclic? x => error "cyclic list"
@@ -1495,7 +1495,8 @@
               y := rest y
           empty? x and empty? y

-      node?(u, v) ==
+        node?(u, v) ==
+          empty? v => false
           for k in 0.. while not empty? v repeat
               u = v => return true
               k = cycleMax and cyclic? v => error "cyclic list"
--- a/src/input/bugs2017.input
+++ b/src/input/bugs2017.input
@@ -115,5 +115,9 @@
 sm2 := symmetricTensors(m2, 2)
 testEquals("sm2*sm1", "symmetricTensors(m2*m1, 2)")

+testcase "node? from URAGG"
+
+testTrue("not(node?([],[])$List(Integer))")
+
 )set output algebra on
 statistics()

-- 
You received this message because you are subscribed to the Google Groups 
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/fricas-devel.
For more options, visit https://groups.google.com/d/optout.

Reply via email to