I also checked other usage of factorList and makeFR, and
I think there are no similar bugs.

It's necessary to put notes in the docstrings of factorList and
makeFR, I wonder if it's necessary to rename 'makeFR' to 'makeFR!'.

--- a/src/algebra/fr.spad
+++ b/src/algebra/fr.spad
@@ -44,10 +44,12 @@
     makeFR  : (R, List FF) -> %
       ++ makeFR(unit, listOfFactors) creates a factored object (for
       ++ use by factoring code).
+      ++ Note: the second argument listOfFactors may be shared and modified!

     factorList : % -> List FF
       ++ factorList(u) returns the list of factors with flags (for
       ++ use by factoring code).
+      ++ Note: the result is a shared part of u.

     nilFactor : (R, Integer) -> %
       ++ nilFactor(base, exponent) creates a factored object with

-- 
You received this message because you are subscribed to the Google Groups 
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/fricas-devel.
For more options, visit https://groups.google.com/d/optout.

Reply via email to