oldk1331 wrote:
>
> Thanks, my sourceforge id is also oldk1331.
>
> What's the code review policy? Which patches
> can commit directly?
Normally patches should go to the list for review. Patch
should go in as reviewed -- if there is need for change
new patch should go to the list.
Obvious things can go in without review. Really minor
changes to patches also can go without extra round
of review.
Of course patches should satify technical requirements
(pass test, update documentation when apropriate, contain
tests for changes). I wrote some time ago more about
testing and requirements for patches. Just let me
repeat that patches should be logical unit of change.
Do not join unrelated things unless it is a cleanup type
patch that functionally should be a no-op. OTOH do
not split patches that implement some functionalty into
small steps -- if several patches have common purpose
and there are dependencies between them, then they probably
should go in as one patch. This is not a hard rule,
it make sense to split really large patches (say more
than thousend lines) and sometimes part of functionality
is ready and may be commited before whole thing.
--
Waldek Hebisch
--
You received this message because you are subscribed to the Google Groups
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/fricas-devel.
For more options, visit https://groups.google.com/d/optout.
