Hi Qian,
thanks for your patch. I think, it not only improves speed, but also
fixes a bug. Currently we have
S ==> Set PrimeField(2)
[index(i)$S for i in 1..2^(2+1)]
[{}, {1}, {0}, {1, 0}, {}, {1}, {0}, {1, 0}]
which will give an error after your patch. I support it.
Other issues...
I think there are some potential bugs in the the default package that
comes with the category.
Under convention a function with a name ending in ! modifies its
argument(s) destructively.
In FiniteSetAggregate I see...
difference(s : %, t : %) ==
m := copy s
for x in parts t repeat remove!(x, m)
m
and find this lonely "remove!" troublesome. Shouldn't it rather be
m := remove!(x, m)
http://fricas.github.io/api/FiniteSetAggregate
http://fricas.github.io/api/DictionaryOperations.html#l-dictionary-operations-remove
Ralf
--
You received this message because you are subscribed to the Google Groups
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to fricas-devel+unsubscr...@googlegroups.com.
To post to this group, send email to fricas-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/fricas-devel.
For more options, visit https://groups.google.com/d/optout.
