The patch looks good to me, and the test on Windows CI
passed without problem.
- Qian
On 3/7/21 11:52 PM, Waldek Hebisch wrote:
On Sun, Mar 07, 2021 at 03:07:00PM +0100, Waldek Hebisch wrote:
On Sun, Mar 07, 2021 at 01:04:42PM +0100, Waldek Hebisch wrote:
On Sun, Mar 07, 2021 at 02:32:47PM +0800, Qian Yun wrote:
Spent some time on this, the fix in BOOT compiler is not that
obvious, because of the complexity of escape char at the end
of line.
Shall we simply go with ".gitattributes"?
First we need to decide what carriage return in variuos FriCAS
input files should do and check what it is doing now.
A little experiments shows that FriCAS ignores carriage return at
and of line in .input files and signals error when carriage return
is in middle of line. Boot scanner currently signals error everywhere.
I will try to modify Boot scanner to match .input scanner.
.input scanner simply strips final carriage return in 'expand-tabs'
(in 'macros.lisp'). Boot scanner have no equivalent function,
but I added equivalent code (patch attached) to 'shoeread-line'
and with this code Boot accepts carriage return at end of line.
BTW: I have now enough reasons to rewrite our scanners, but
must wait after release.
--
You received this message because you are subscribed to the Google Groups "FriCAS -
computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/fricas-devel/48ed3bdc-0cac-b77b-63ee-a539b069c54e%40gmail.com.
