On Wed, Jun 29, 2022 at 10:00:21PM +0800, Qian Yun wrote: > I don't know if these 2 patches reached Waldek's mailbox or otherwise. > > (BTW, lynx can browse through https://github.com/fricas/fricas/pulls > to see open PRs.) > > They were submitted 10 days ago and I hope to get reviews. > > https://github.com/fricas/fricas/pull/93
93 looks OK. ICARD has many problems so I was thinking if we should do some major fixup or just merge this one. But it is probably better just to merge this fix. > https://github.com/fricas/fricas/pull/96 > > For Paul's PR#96, I have verified his patch fixes the bug. Hmm, AFAICS 96 is from you. I wrote the following in comment section, but github apparently sent it to black hole: I admit that it is not clear for me why you want this. At least some of places that you want to modify comunicate with C code. And in C code all we have is FRICAS environment variable (we definitely do not have access to Lisp '$spadroot'). IIUC you wrote that passing environment variables on Mac OS is tricky. Having some fallback is reasonable, but preferably this fallback should be in one place, at top of process tree. And once fallback is established it should be propagated down via environment. My feeling is that in longer term is is better to learn how to propagate environment variables on Mac OS. Otherwise, we risk that hacks which are reasonable as "point" solution spread out to many places creating hard to maintain mess. -- Waldek Hebisch -- You received this message because you are subscribed to the Google Groups "FriCAS - computer algebra system" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/fricas-devel/20220629150539.GA8982%40fricas.math.uni.wroc.pl.
