On Mon, May 15, 2023 at 12:47:37AM +0200, Ralf Hemmecke wrote:
> Thank you, Peter, for investing your time into this.
>
> Since this stuff concerns FriCAS code, I crosspost to fricas-devel.
>
> Obviously, Waldek missed some places while renaming $ to %.
>
> In my branch https://github.com/hemmecke/fricas/tree/dollar-percent
>
> https://github.com/hemmecke/fricas/commit/e7c4cca1aaa3e24951a9b826ffc0fdf9ab18586b.patch
>
> I have collected more suspicious places (where I have replaced $ by % --
> maybe not all correct, but should be considered).
Quick comment about changes:
1) $$ is different than $, no need for replacement.
Similarly $$$ is different than $ and $$, no need for replacement.
So changes to br-data.boot, compiler.boot, define.boot, modemap.boot,
nruncomp.boot, nrunfast.boot, nrungo.boot, nrunopt.boot,
i-map.boot, i-spec1.boot, i-spec2.boot, third and fifth
change to interop.boot, are not needed
2) in format.boot second change is wrong, we want $ here.
AFAICS formatOpConstant is unused, so better remove it.
Third change looks good.
Similarly, first change to i-output.boot is wrong (second is good).
3) I am not sure about change to trace.boot, but it is likely to
be wrong.
4) For Aldor you probably only need changes to as.boot and 3 of the
changes to interop.boot.
--
Waldek Hebisch
--
You received this message because you are subscribed to the Google Groups
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to fricas-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/fricas-devel/20230515015923.yqkmpwfyxkvocltk%40fricas.math.uni.wroc.pl.
