Hello Waldek, I just cloned fricas.git (configure.ac : 2023-07-17 20:19:21.130766889 +0200 on my drive).
And I guess your patch can not be used with recent Git version, am I right? With SBCL-2.3.6 no problem without your patch. But if I (successfully) apply your patch here is the output of 'make check': ===================================== 26 failing files: bugs2007.output: 18 bugs2008.output: 8 bugs2009.output: 9 bugs2010.output: 7 bugs2012.output: 5 bugs2013.output: 4 bugs2014.output: 5 bugs2015.output: 4 bugs2016.output: 2 bugs2017.output: 24 bugs2018.output: 3 bugs2019.output: 1 bugs2020.output: 1 bugs2021.output: 4 bugs2022.output: 1 bugs2023.output: 4 derham.output: 21 distro.output: 1 ellip.output: 2 integ.output: 1072 limit.output: 63 lode.output: 13 mantepse.output: 24 polylift.output: 1 psgenfcn.output: 2 series3.output: 14 ===================================== That should be reproducible I think, so I did not attach the .output files. If that's necessary I can put a tarball on my Google Drive and give a link to it. __ Greg Le dim. 16 juil. 2023 à 22:40, Waldek Hebisch <de...@fricas.math.uni.wroc.pl> a écrit : > > On Sat, Jul 15, 2023 at 01:12:08AM +0200, Ralf Hemmecke wrote: > > > > But hey, I see > > > > https://github.com/fricas/fricas/blob/master/src/algebra/multpoly.spad#L647 > > > > degree p == > > p case R => 0 > > degree(leadingCoefficient(p.ts)) + monomial(degree(p.ts), p.v) > > > > Oh, no! That computes the degree over all variables. It basically treat the > > polynomial like in a distributed fashion. Sorry, I have not recognized this > > before. > > > > For an implementation of the smaller? from Compare in SMP, I would > > definitely use the univariate recursive structure, i.e. consider the degree > > function from D and eventually break ties with smaller? from R. > > I have now version of 'smaller?' for SMP. I tried to get the same > results as older version. Good news is that when it works it > seem to be about 4 times faster than old version. Bad news is > that at least using sbcl it breaks in strange ways: printouts > show correct values, but it from time to time it dies with > Lisp errors. To complicate matter, it seem that after > succesfull call with given argument some time later it can > fail with the same arguments. It seems to work with ecl. ATM > it looks to me like a miscomplilation. But it is not clear > whom to blame, if our declaration/initialization is wrong > or it the error is on Lisp side. > > If anybody wants to try this code and investigate problems > the patch is in attachement. > > BTW: There is a chunk for ZMOD, this one seem to be working > fine. > > -- > Waldek Hebisch > > -- > You received this message because you are subscribed to the Google Groups > "FriCAS - computer algebra system" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to fricas-devel+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/fricas-devel/ZLRVr78748xllTd3%40fricas.math.uni.wroc.pl. -- You received this message because you are subscribed to the Google Groups "FriCAS - computer algebra system" group. To unsubscribe from this group and stop receiving emails from it, send an email to fricas-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/fricas-devel/CAHnU2dboSK9yEGCWbPVgSaJpBJWT0SVjrWcCSnTNoqgTULKmkA%40mail.gmail.com.
