On 11/18/23 11:03, Waldek Hebisch wrote:
On Wed, Nov 15, 2023 at 06:00:26PM +0800, Qian Yun wrote:
This is a relatively large misc cleanup, so I'd like a review before
commit.
Looks mostly good. But I have doubts about two changes to
fricas-lisp.lisp. First, removing extern declaration of 'sock_get_float'
looks dangerous. Namely, extern declarations are needed.
We provide extern declarations for ECL in 'ecl-foreign-call',
but we do not do this for GCL. Is GCL providing extern
declarations? If not we need our own. Second, I do not
The other externs were removed in commit 84fc10e4 in 2008, only this
one remains.
From GCL documentation:
In order for C code to be loaded in by load you should declare any
variables and functions to be static. If you will link them in at
build time, of course you are allowed to define new externals.
So declarations are needed when you want to load the compiled file
in interpreter. Since we are linking the .o files, this is not a
problem.
know why you want to move definition of 'sockSendString'?
It is closely related to 'sock_send_string_len' and keeping
them together looks clearer for me.
It is enclosed in "foreign-defs", which is defined differently
for CMUCL and CLISP. So for consistency, I'd like to move
it out of "foreign-defs".
- Qian
A question: shall we remove GCL_DIST related stuff in
src/scripts/mkdist.sh?
Probably. It was not used for many years and there is low probability
that it will be needed in the future.
--
You received this message because you are subscribed to the Google Groups "FriCAS -
computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to fricas-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/fricas-devel/6c7c43e3-0672-40e3-9e18-de6d7a738b1d%40gmail.com.
