On Tue, Apr 02, 2024 at 07:51:53PM +0800, Qian Yun wrote:
> It is caused by commit 68a3e8ee in 2023-Feb-9, the removal of
> "makePathname" in "histInputFileName".
>
> So the fix is the following. Please review it before I do the
> commit.
AFAICS the PNAME part is not needed: make_filename0 converts
symbols to strings.
At first glance, it looks that change below would break
')history )save' and ')undo'. I think that we need to change
'historySpad2Cmd' to call an intermediate function to
convert arguments.
>
> - Qian
>
> diff --git a/src/interp/i-syscmd.boot b/src/interp/i-syscmd.boot
> index 8e337d59..37c0e6ea 100644
> --- a/src/interp/i-syscmd.boot
> +++ b/src/interp/i-syscmd.boot
> @@ -1308,7 +1308,7 @@ histFileName() ==
> histInputFileName(fn) ==
> null fn =>
> make_filename0($interpreterFrameName, 'INPUT)
> - make_filename0(fn, 'INPUT)
> + make_filename0(PNAME fn, 'INPUT)
>
>
> initHist() ==
> @@ -1427,6 +1427,7 @@ writeInputLines(fn,initial) ==
> -- in case we can't find a breaking point
> if not done then n := 0
> lineList := [vec,:lineList]
> + fn := first(fn)
> file := histInputFileName(fn)
> maybe_delete_file(file)
> inp := MAKE_OUTSTREAM(file)
>
>
>
> On 4/2/24 16:50, Prof. Dr. Johannes Grabmeier wrote:
> > in my recent installed system
> >
> > FriCAS Computer Algebra System
> > Version: FriCAS 1.3.10 built with sbcl 2.4.0
> > Timestamp: Mo 11 Mär 2024 17:56:31 CET
> > -----------------------------------------------------------------------------
> > Issue )copyright to view copyright notices.
> > Issue )summary for a summary of useful system commands.
> > Issue )quit to leave FriCAS and return to shell.
> > --------------------------------------------------------------------------
> >
> > the history feature is broken:
> >
> > (3) -> x+y
> >
> > (3) y + x
> > Type: Polynomial(Integer)
> > (4) -> )history )write xx
> >
> > debugger invoked on a SIMPLE-CONDITION in thread
> > #<THREAD "main thread" RUNNING {7006620003}>:
> > break
> >
> > Type HELP for debugger help, or (SB-EXT:EXIT) to exit from SBCL.
> >
> > restarts (invokable by number or by possibly-abbreviated name):
> > 0: [CONTINUE] Return from BREAK.
> > 1: [ABORT ] Exit from the current thread.
> >
> > (|writeInputLines| (|xx|) 1)
> > source: (|histInputFileName| |fn|)
> > 0]
> >
> >
> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "FriCAS - computer algebra system" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/fricas-devel/d01bdbc8-c95e-44ec-9cb3-38f511d34e8d%40gmail.com.
--
Waldek Hebisch
--
You received this message because you are subscribed to the Google Groups
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/fricas-devel/ZgxJudwptKCMRayH%40fricas.org.
