2011/7/5 Wols Lists <[email protected]>: > On 05/07/11 21:29, Jan Warchoł wrote: >> Could you send me a link to the previous discussion on this topic? A >> quick search didn't return anything. > > Look for frog emails with a subject containing "chord-name-engraver"
Ah, i forgot that i should look on frogs, not on devel. > from august last year ... yes I know it's a long time ... i have a patch that is a work in progress since half a year. So don't worry about long pauses :) > but 2.14 was > supposed to be out rsn back then :-) and life happened to me :-) > > Just to give a quick overview of the purpose of the changes - let's say > you've got a piano sheet with guitar chords. Very often, it'll be in a > naff key for the guitar and you want to display the guitar chords > transposed by a capo. > > So if the actual chord is C, and you want capo 3, you want the chord to > actually print as "C (A)", ie the original chord followed by the > transposed chord in brackets. Ah, perfect! This explains everything. I play guitar a bit too and i like your idea! I didn't know that such a notation was commonly used. >> If you have any problem with Rietveld, i'll gladly help you; I can >> upload your patch if you want. >> >> cheers, >> Janek >> > Patch attached. I've looked at the web page for rietveld, and I run > gentoo so things do "just build" for me (gentoo bugs excepted :-) Do I > need the git-cl stuff? Yes, you need git cl to upload to Rietveld (AFAIK). http://lilypond.org/doc/v2.15/Documentation/contributor/commits-and-patches#uploading-a-patch-for-review says something about it. But don't worry now, as i've just uploaded it: http://codereview.appspot.com/4626094/ I don't know what LilyDev is, but I guess I > haven't got it ... LilyDev isn't necessary for Rietveld. > If you look at the patch, the idea is that all of my changes (apart from > the initial setting of bool capo) should be set inside an "if capo" > conditional, so if the user doesn't set capoPitch, lily doesn't go > anywhere near my code. Good. I'll take a closer look tomorrow. thanks, Janek --- ---- Join the Frogs!
