Hi, On Fri, Dec 14, 2012 at 10:32:45AM +0100, Trebór Kikadf <[email protected]> wrote: > +if [ -n "$_F_github_tag" ]; then > + #### > + # * Funpack_github() unpack zipball if source has in $url/tags. > + #### > + Funpack_github() > + { > + unzip -o -q $_F_github_ver > + } > + > + #### > + # * build() just calls Funpack_github and Fbuild > + #### > + build() > + { > + Funpack_github > + Fbuild > + } > fi
No need to add the fancy ### comments if the code is indented.
source/include/Makefile only searches for ^###, so either just add a
normal comment or enable these functions by default, and use:
if [ -n "$_F_github_tag" ]; then
Funpack_github
fi
to avoid unpacking in the non-tag case.
Otherwise looks good, feel free to push it!
Thanks,
Miklos
signature.asc
Description: Digital signature
_______________________________________________ Frugalware-devel mailing list [email protected] http://frugalware.org/mailman/listinfo/frugalware-devel
