I figured it out; the problem is that Debian uses /bin/dash as the
default shell (which is good, it meant that most Debian systems didn't
get screwed by the bash security hole). But it's also bad, because
xfstests has a few /bin/bashisms. Normally, this isn't a problem
because most of the scripts are started by #!/bin/bash. However, on
my test system fsgqa had a shell of /dev/sh, and in Debian this is
/bin/dash.
So there are a couple of ways I can fix this.
1) Document in README that fsgqa must use a shell of fsgqa to
/bin/bash or some tests might fail.
2) Change _user_do() to use "su -s /bin/bash $qa_user ...".
3) Change tests/generic/256 so that instead of
_user_do "$XFS_IO_PROG -f -c \"pwrite 0 $file_size\"
$dir/$file_count.bin &> /dev/null"
we use:
_user_do "$XFS_IO_PROG -f -c \"pwrite 0 $file_size\"
$dir/$file_count.bin > /dev/null 2>&1"
or:
_user_do "$XFS_IO_PROG -f -c \"pwrite 0 $file_size\"
$dir/$file_count.bin" &> /dev/null
Any preference which patch, if any, I should send? (If #1, then we
probably document the fact that fsgqa must have a shell of bash).
Thanks,
- Ted
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
