On 4/3/15 7:14 AM, Eryu Guan wrote: > Tests take use of dm-flakey target should require metadata journaling, > so move _require_metadata_journaling call from each test to > _require_dm_flakey to ease the process, though it seems unnecessary to > btrfs or xfs specific tests. > > This change also makes generic/039 generic/059 generic/325 require > metadata journaling automatically, and any new test that calls > _require_dm_flakey.
I'm not sure this is a great idea... I think _require_metadata_journaling should only be used when we expect filesystem consistency after a (flakey) shutdown. We can use dm_flakey to test fsync persistence on vfat, for example, right? But with this change such a test won't run on vfat or many other filesystems even though the test for persistent data would be perfectly valid. -Eric -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
