Добрый день, Антон Good day, Anton, I considered different ways of implementation. At least two of them: 1. Store user name in request until user log-in. 2. Retrieve user by user name from UserManager, but set the flag, that it is not init yet.
I selected first way, because there is possibility to create UserManager which can retrieve user only with user name and password. So we need to store user name. But I prefer to do it in new class, Credentials, instead of using new String field, because it is more readable and understandable from my point of view. So by this patch I "fix" two issues at one time: 1. Partially replace BaseUser with it UserManager specific implementation 2. Remove User from Request until User is logged-in. Sergey 2006/5/5, Anton Goldberg <[EMAIL PROTECTED]>:
Hi Sergey, (or should I say Sdravstvuy!). I looked through your patch and while I totally agree with the idea behind the patch I don't quite understand the implementation. Let me go into more details here. As far as I understand UserManager works like a Factory (pattern) for User. I.e. the particular implementation of UserManager knows what specific class implementing User interface it needs to instantiate. So the default (BaseUser) implementation should be replaced by UserManager supplied implementation on log-in. (PASS/USER commands). As a thing that gets replaced BaseUser works just fine, without introducing the new class Credentials, because Credentials exposes a subset of User (and BaseUser) functionality. Now I have a slightly different issue - if you noticed, I didn't reply to the list. The reason being that while I subscribed to the list fine, I am unable to post from any of my email addresses - I tryed my workaddress, this gmail account and also my personal mail server. I wonder if you in your contributor role could check it out and let me know what might be the reason I can not post. You are quite welcome to reply in Russian, my email client can read russian letters just fine. -- Anton
-- Sergey Vladimirov
