Yes, this appears to be a good general solution. At least for my purposes, this would eliminate the need for Ftplet.onLoginFail().
I intended to test the patch before replying, but I ran into a hitch due to my unfamiliarity with Apache projects: I attempted to apply the patch to a copy of the source obtained from the Download link on the Apache FTP Server home page. This worked well until I got to ServerFtpStatistics.java, which doesn't exist in that version of the source. I do see it in the Subversion repository. This raises the question: How often is the source from the repository packaged into the zip and tar files available from the Download link? I've been working from the zipped source as a base, but if the trunk from the repository is equally stable, I will switch to that. By the way, I have made some changes myself that may be of general interest, such as the addition of an IThreadFactory interface. I gather the first step for submitting these is to create an issue and attach some kind of standardized diff output representing the change. I assume subversion has a tool for doing this, but I could some tips regarding the overall procedure for submitting changes. If you can direct me to further information, I would appreciate it. Clint --------------------------------------------------------------------------- On 11/30/06 12:04 PM, "Niklas Gustavsson (JIRA)" <[EMAIL PROTECTED]> wrote: > [ > http://issues.apache.org/jira/browse/FTPSERVER-52?page=comments#action_1245472 > 8 ] > > Niklas Gustavsson commented on FTPSERVER-52: > -------------------------------------------- > > Clinton, would this patch address your needs or would you also like the change > to the FtpLet interface? > >> Add onLoginFail() to Ftplet interface >> ------------------------------------- >> >> Key: FTPSERVER-52 >> URL: http://issues.apache.org/jira/browse/FTPSERVER-52 >> Project: FtpServer >> Issue Type: Improvement >> Reporter: Clinton Foster >> Assigned To: Niklas Gustavsson >> Priority: Minor >> Attachments: Apache FTPServer Core.patch >> >> >> Particularly in cases where the FTP server is embedded in another >> application, it is important to be able to determine the IP address of the >> remote client when authentication fails. One possibility would be to provide >> access to the remote address from UserManager.authenticate(). (This might be >> useful for other reasons as well.) A more generic approach that would not >> require a custom UserManager implementation would be to add an onLoginFail() >> method to the Ftplet interface. I think both enhancements would be useful, >> although if only one or the other could be done I would favor adding >> Ftplet.onLoginFail().
