[ 
https://issues.apache.org/jira/browse/FTPSERVER-106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Birkir A. Barkarson updated FTPSERVER-106:
------------------------------------------

    Description: 
org.apache.ftpserver.clienttests.PasvTest  fails on system with IPv6 addresses.

TestUtils.getHostAddresses() returns IP addresses for all interfaces on the 
system and on a dual stack system that includes IPv6 addresses.
Not sure if the FtpServer is supposed to support IPv6 (since that would affect 
server response to stuff like PASV), but I will include a temporary fix for 
TestUtils below.

Index: 
/srv/home/birkirb/svn/ftpserver/core/src/test/org/apache/ftpserver/test/TestUtil.java
===================================================================
--- 
/srv/home/birkirb/svn/ftpserver/core/src/test/org/apache/ftpserver/test/TestUtil.java
       (revision 570339)
+++ 
/srv/home/birkirb/svn/ftpserver/core/src/test/org/apache/ftpserver/test/TestUtil.java
       (working copy)
@@ -105,7 +105,14 @@
             
             while (ips.hasMoreElements()) {
                 InetAddress ip = (InetAddress) ips.nextElement();
-                hostIps.add(ip.getHostAddress());
+                if(ip instanceof java.net.Inet4Address)
+                {
+                       hostIps.add(ip.getHostAddress());
+                }
+                else
+                {
+                       // IPv6 not tested
+                }
             }
         }
         


  was:
org.apache.ftpserver.clienttests.PasvTest  fails on system with IPv6 addresses.

TestUtils.getHostAddresses() returns IP addresses for all interfaces on the 
system and on a dual stack system that includes IPv6 addresses.
Not sure if the FtpServer is supposed to support IPv6 (since that would affect 
server response to stuff like PASV), but I will include a temporary fix for 
TestUtils.



> Test failure on system with IPv4 and IPv6 dual stack
> ----------------------------------------------------
>
>                 Key: FTPSERVER-106
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-106
>             Project: FtpServer
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0-M2
>         Environment: Fedora 7 Linux 2.6.22.4-65.fc7
> java version "1.5.0_12"
>            Reporter: Birkir A. Barkarson
>            Priority: Minor
>             Fix For: 1.0-M2
>
>
> org.apache.ftpserver.clienttests.PasvTest  fails on system with IPv6 
> addresses.
> TestUtils.getHostAddresses() returns IP addresses for all interfaces on the 
> system and on a dual stack system that includes IPv6 addresses.
> Not sure if the FtpServer is supposed to support IPv6 (since that would 
> affect server response to stuff like PASV), but I will include a temporary 
> fix for TestUtils below.
> Index: 
> /srv/home/birkirb/svn/ftpserver/core/src/test/org/apache/ftpserver/test/TestUtil.java
> ===================================================================
> --- 
> /srv/home/birkirb/svn/ftpserver/core/src/test/org/apache/ftpserver/test/TestUtil.java
>      (revision 570339)
> +++ 
> /srv/home/birkirb/svn/ftpserver/core/src/test/org/apache/ftpserver/test/TestUtil.java
>      (working copy)
> @@ -105,7 +105,14 @@
>              
>              while (ips.hasMoreElements()) {
>                  InetAddress ip = (InetAddress) ips.nextElement();
> -                hostIps.add(ip.getHostAddress());
> +                if(ip instanceof java.net.Inet4Address)
> +                {
> +                     hostIps.add(ip.getHostAddress());
> +                }
> +                else
> +                {
> +                     // IPv6 not tested
> +                }
>              }
>          }
>          

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to