I propose that we make this method standard for bringing in external puppet modules.
Currently we have reviews open to add puppet-mongodb: +2397 lines puppet-elasticsearch: +1897 lines puppet-logstash: +38117 lines zabbix server: +888 lines zabbix types: +4494 lines > However big commits like this are near impossible to review. > > I propose that whenever we are taking from a upstream library that we need > to follow a new process > 1. Create a review request with a verbatim copy of the upstream module and > no other related modifications. This review should also contain the commit > hash from the upstream repo in the commit message. The review should be > looked over for reasons for rejecting the entire module, such as license > issues. Forbearing such issues it should be accepted with out requiring > modifications. > > 2. Any changes necessary to make it work with fuel can then be proposed as > a dependent change(s) > > This will allow us to review what we are actually changing to support fuel > and should accelerate reviews. It also allows us some ability to identify > where we diverged from upstream in the case that we want to push changes > back up. It also allows us to identify what we changed in the case that the > upstream license requires such tracking. > -- Andrew Mirantis Ceph community
-- Mailing list: https://launchpad.net/~fuel-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~fuel-dev More help : https://help.launchpad.net/ListHelp
