OK, let me rephrase. Our kickstart configures eth0 according to the kernel parameters we passed, right? If we run fuelmenu with "--save-only" it uses actual "eth0" IP settings, calculates everything it needs and saves this info in /etc/astute.yaml. But if we enter Fuel menu and exit without saving, it resets everything to defaults (10.20.0.0/24) and saves these defaults in /etc/astute.yaml. To my mind, "exit without saving" should act like "save-only".
In order to avoid misunderstandings you mentioned, we can remove "Save and continue" and leave only 2 options: "Quit without saving" and "Save and exit" On Wed, Apr 30, 2014 at 9:45 AM, Matthew Mosesohn <[email protected]>wrote: > We can't load these kernel parameters in because the system already > rebooted out of anaconda and those were only set one time during install. > > Exit without saving will have negative effects if the user makes changes, > saves them, then exits without saving. What if I switched PXE interface to > eth2, then save, then exit without saving? It will reset PXE interface to > eth0 and break deployment. > > > On Wed, Apr 30, 2014 at 10:34 AM, Aleksandr Didenko <[email protected] > > wrote: > >> Hi, >> >> I think we should either "load" kernel parameters into Fuel menu instead >> of hardcoded defaults, or run "--save-only" if user chooses "Exit without >> saving" (so it behave exactly the same way as if user did not enter >> fuelmenu at all). The bottom line is that Fuel menu should not break/reset >> settings passed via kernel parameters if we exit without saving. >> >> >> On Tue, Apr 29, 2014 at 9:28 PM, Matthew Mosesohn <[email protected] >> > wrote: >> >>> Forgot to include bug link: https://bugs.launchpad.net/fuel/+bug/1314224 >>> >>> >>> On Tue, Apr 29, 2014 at 10:27 PM, Matthew Mosesohn < >>> [email protected]> wrote: >>> >>>> Hi Fuelers! >>>> >>>> I was wondering if you guys had some input on this dilemma. If you >>>> deploy Fuel master node and do the following steps, your astute.yaml config >>>> will be wrong: >>>> 1 - Boot from ISO >>>> 2 - Modify network parameters inside isolinux prompt >>>> 3 - Install and enter Fuelmenu >>>> 4 - Exit without saving >>>> >>>> The workflow I put in place to solve half this problem was to write >>>> astute.yaml config via a "--save-only" option that runs if showmenu=no. But >>>> if you enter Fuelmenu and then don't save, this doesn't get run. Should we >>>> run --save-only every time? If we launch Fuelmenu and try to save >>>> automatically as soon asit runs, it will try to run all checks and then >>>> possibly error and give ugly warnings that ruin user experience. >>>> The alternative is to convince the user to save changes and go back. >>>> >>>> I vote for the latter option, personally, mostly because we removed all >>>> the kernel parameter configuration information from our user guide over 6 >>>> months ago, so we shouldn't be trying to cover edge cases where you >>>> modified an undocumented feature and then failed to save when you launched >>>> the tool. >>>> >>>> I really do need your feedback so we can decide if this is a priority >>>> to fix, and also how to fix it. >>>> >>>> Best Regards, >>>> Matthew Mosesohn >>>> >>> >>> >>> -- >>> Mailing list: https://launchpad.net/~fuel-dev >>> Post to : [email protected] >>> Unsubscribe : https://launchpad.net/~fuel-dev >>> More help : https://help.launchpad.net/ListHelp >>> >>> >> >
-- Mailing list: https://launchpad.net/~fuel-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~fuel-dev More help : https://help.launchpad.net/ListHelp
