[email protected] wrote:
*** func/minion/server.py       2009-02-26 15:38:14.000000000 -0800
--- func/minion/server.py.orig  2009-02-26 15:29:45.000000000 -0800
***************
*** 178,189 ****
      listen_port = config.listen_port
      if listen_port == '':
          listen_port = 51234
!     try:
!         server =FuncSSLXMLRPCServer((listen_addr, int(listen_port)))
!         server.logRequests = 0 # don't print stuff to console
!         server.serve_forever()
!     except Exception, e:
!         logger.Logger().logger.error(e)
Definitely need to int'ify that option (and probably strip it too if the config doesn't already).

The try/except stuff would be handled by the default exception handler now that logs. But should probably add it anyway for cases we can expect ("port already in use" comes to mind) with
more useful error reporting.

Adrian

--- 178,186 ----
      listen_port = config.listen_port
      if listen_port == '':
          listen_port = 51234
!     server =FuncSSLXMLRPCServer((listen_addr, listen_port))
!     server.logRequests = 0 # don't print stuff to console
!     server.serve_forever()


_______________________________________________
Func-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/func-list

Reply via email to