This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "FusionForge".
The branch, 6.0 has been updated
via caef270d5dc7582fe5d9b0e41a069135e329d082 (commit)
from 1c81c9af0fbc67212109e869e17c53f5b1ea7ea0 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit caef270d5dc7582fe5d9b0e41a069135e329d082
Author: Sylvain Beucler <[email protected]>
Date: Wed May 27 16:14:57 2015 +0200
systasksd: while umask(0) is recommended for daemons, this is likely to
introduce bugs and security issues
diff --git a/src/bin/systasksd b/src/bin/systasksd
index db8a416..7130077 100755
--- a/src/bin/systasksd
+++ b/src/bin/systasksd
@@ -89,7 +89,8 @@ if (isset($options['v']) or isset($options['verbose'])) {
// Proper daemon
posix_setsid();
chdir('/');
-umask(0);
+//umask(0); // programmers usually expect umask=0022, and this would default
mkdir to 0777
+umask(0022);
$log_path = forge_get_config('log_path');
if (!$verbose) {
// Hack to reopen stdin/stdout/stderr, order is important
-----------------------------------------------------------------------
Summary of changes:
src/bin/systasksd | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/bin/systasksd b/src/bin/systasksd
index db8a416..7130077 100755
--- a/src/bin/systasksd
+++ b/src/bin/systasksd
@@ -89,7 +89,8 @@ if (isset($options['v']) or isset($options['verbose'])) {
// Proper daemon
posix_setsid();
chdir('/');
-umask(0);
+//umask(0); // programmers usually expect umask=0022, and this would default
mkdir to 0777
+umask(0022);
$log_path = forge_get_config('log_path');
if (!$verbose) {
// Hack to reopen stdin/stdout/stderr, order is important
hooks/post-receive
--
FusionForge
_______________________________________________
Fusionforge-commits mailing list
[email protected]
http://lists.fusionforge.org/cgi-bin/mailman/listinfo/fusionforge-commits
