This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "FusionForge".

The branch, master has been updated
       via  fdc2d3831a0ddf2c952bf1536ae12a3962dfc540 (commit)
      from  8f49b6b6b20c981bce8e56198eac4fc668dedab2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://scm.fusionforge.org/anonscm/gitweb/?p=fusionforge/fusionforge.git;a=commitdiff;h=fdc2d3831a0ddf2c952bf1536ae12a3962dfc540

commit fdc2d3831a0ddf2c952bf1536ae12a3962dfc540
Author: Franck Villaume <[email protected]>
Date:   Thu Nov 3 15:25:25 2016 +0100

    fix PHP notice & remove double tests

diff --git a/src/plugins/taskboard/common/include/TaskBoardHtml.class.php 
b/src/plugins/taskboard/common/include/TaskBoardHtml.class.php
index 6ebc77d..f0f74a3 100644
--- a/src/plugins/taskboard/common/include/TaskBoardHtml.class.php
+++ b/src/plugins/taskboard/common/include/TaskBoardHtml.class.php
@@ -41,11 +41,11 @@ class TaskBoardHtml extends TaskBoard {
 
                $labels[] = _('View Taskboards');
                $links[]  = '/plugins/taskboard/?group_id='.$group_id;
-               $attr   = array(array('title' => _('Get the list of available 
taskboards')));
+               $attr     = array(array('title' => _('Get the list of available 
taskboards')));
                if (session_loggedin()) {
                        if (forge_check_perm('tracker_admin', $group_id)) {
                                $labels[] = _('Taskboards Administration');
-                               $links[]  = 
'plugins/taskboard/admin/?group_id='.$group_id;
+                               $links[]  = 
'/plugins/taskboard/admin/?group_id='.$group_id;
                                $attr[]   = array('title' => _('Global 
administration for taskboards.'));
                        }
                }
@@ -65,34 +65,33 @@ class TaskBoardHtml extends TaskBoard {
                        if (forge_check_perm('tracker_admin', $group_id)) {
                                $release_id = 
getIntFromRequest('release_id','');
                                $view = getStringFromRequest('view','');
-                               if($release_id) {
+                               if ($release_id) {
                                        if( $view == 'edit_release' ) {
                                                $labels[] = _('Delete release');
                                                $links[]  = 
'/plugins/taskboard/releases/?group_id='.$group_id.'&taskboard_id='.$taskboard_id.'&release_id='.$release_id.'&view=delete_release';
+                                               $attr[]   = array();
                                        } else {
                                                $labels[] = _('Edit release');
                                                $links[]  = 
'/plugins/taskboard/releases/?group_id='.$group_id.'&taskboard_id='.$taskboard_id.'&release_id='.$release_id.'&view=edit_release';
+                                               $attr[]   = array();
                                        }
                                }
-                       }
-               }
 
-               if (session_loggedin()) {
-                       if (forge_check_perm('tracker_admin', $group_id)) {
                                if ($taskboard_id) {
                                        $labels[] = _('Administration');
                                        $links[]  = 
'/plugins/taskboard/admin/?group_id='.$group_id.'&taskboard_id='.$taskboard_id;
                                        $attr[]   = array('title' => 
_('Administration for this taskboard.'));
                                }
-                               $view = getStringFromRequest('view');
+
                                if ($view == 'edit_column') {
                                        $labels[] = _('Configure Columns');
                                        $links[]  = 
'/plugins/taskboard/admin/?group_id='.$group_id.'&taskboard_id='.$taskboard_id.'&view=columns';
-
+                                       $attr[]   = array();
                                        $column_id = 
getIntFromRequest('column_id', '');
                                        if ($column_id) {
                                                $labels[] = _('Delete Column');
                                                $links[]  = 
'/plugins/taskboard/admin/?group_id='.$group_id.'&taskboard_id='.$taskboard_id.'&column_id='.$column_id.'&view=delete_column';
+                                               $attr[]   = array();
                                        }
                                }
                        }

-----------------------------------------------------------------------

Summary of changes:
 .../taskboard/common/include/TaskBoardHtml.class.php    | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
FusionForge

_______________________________________________
Fusionforge-commits mailing list
[email protected]
http://lists.fusionforge.org/cgi-bin/mailman/listinfo/fusionforge-commits

Reply via email to