This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "FusionForge".
The branch, master has been updated
via 8fbaa2df473142ca04d1877a18c008d6dc89eed4 (commit)
from db97a81554e250c5bb262f057ebc38c7f04c2157 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://scm.fusionforge.org/anonscm/gitweb/?p=fusionforge/fusionforge.git;a=commitdiff;h=8fbaa2df473142ca04d1877a18c008d6dc89eed4
commit 8fbaa2df473142ca04d1877a18c008d6dc89eed4
Author: Franck Villaume <[email protected]>
Date: Mon Nov 21 16:30:15 2016 +0100
fix setAsDefault. wrong var and wrong logic on return value
diff --git a/src/common/tracker/ArtifactExtraFieldElement.class.php
b/src/common/tracker/ArtifactExtraFieldElement.class.php
index a784cfc..8ef23d8 100644
--- a/src/common/tracker/ArtifactExtraFieldElement.class.php
+++ b/src/common/tracker/ArtifactExtraFieldElement.class.php
@@ -303,10 +303,10 @@ class ArtifactExtraFieldElement extends FFError {
/**
* setAsDefault - set this field element as default value or not.
*
- * @param isDefault boolean true-> set as default,
false->unset as default
+ * @param is_default boolean true-> set as default,
false->unset as default
* @return boolean
*/
- function setAsDefault($isDefault) {
+ function setAsDefault($is_default) {
if ($this->isDefault() && !$is_default) {
$result = db_query_params ('DELETE FROM
artifact_extra_field_default WHERE extra_field_id = $1 AND default_value = $2',
array
($this->ArtifactExtraField->getID(), $this->getID()));
@@ -329,8 +329,9 @@ class ArtifactExtraFieldElement extends FFError {
$this->setError(db_error());
return false;
}
+ return true;
}
- return true;
+ return false;
}
-----------------------------------------------------------------------
Summary of changes:
src/common/tracker/ArtifactExtraFieldElement.class.php | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
hooks/post-receive
--
FusionForge
_______________________________________________
Fusionforge-commits mailing list
[email protected]
http://lists.fusionforge.org/cgi-bin/mailman/listinfo/fusionforge-commits
