This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "FusionForge".
The branch, master has been updated
via 7d60ada5911a406b4d15bab18ebb2414c1988183 (commit)
from 7a2b1c5ffdc85eedc9ef0a1bd425a8f9ba1ac18e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://scm.fusionforge.org/anonscm/gitweb/?p=fusionforge/fusionforge.git;a=commitdiff;h=7d60ada5911a406b4d15bab18ebb2414c1988183
commit 7d60ada5911a406b4d15bab18ebb2414c1988183
Author: Franck Villaume <[email protected]>
Date: Fri May 7 09:45:49 2021 +0200
clean-up: remove unused vars
diff --git a/src/common/include/plugins_utils.php
b/src/common/include/plugins_utils.php
index b841da6..89ee1cf 100644
--- a/src/common/include/plugins_utils.php
+++ b/src/common/include/plugins_utils.php
@@ -1,7 +1,7 @@
<?php
/**
* Copyright 2010 (c) Mélanie Le Bail
- * Copyright 2014,2015, 2019, Franck Villaume - TrivialDev
+ * Copyright 2014,2015,2019,2021, Franck Villaume - TrivialDev
* Copyright 2015, Sieu Truc
* http://fusionforge.org
*
@@ -64,8 +64,7 @@ function htmlIframe($url, $poub = array()) {
}
function htmlIframeResizer($url, $poub = array(), $resizeOpt = array()) {
- global $HTML, $group_id;
- $project = group_get_object($group_id);
+ global $HTML;
if (isset($poub['id'])) {
$id = $poub['id'];
} else {
diff --git a/src/common/include/session.php b/src/common/include/session.php
index d9111ab..30542d4 100644
--- a/src/common/include/session.php
+++ b/src/common/include/session.php
@@ -7,7 +7,7 @@
* Copyright 2004-2005, GForge, LLC
* Copyright © 2013
* Thorsten “mirabilos” Glaser <[email protected]>
- * Copyright 2013,2016, Franck Villaume - TrivialDev
+ * Copyright 2013,2016,2021, Franck Villaume - TrivialDev
*
* This file is part of FusionForge. FusionForge is free software;
* you can redistribute it and/or modify it under the terms of the
@@ -203,7 +203,7 @@ function session_login_valid($loginname, $passwd,
$allowpending = 0) {
$plugin_session_login_valid = false;
// Refuse login if not all the plugins are ok.
- foreach ($hook_params['results'] as $p => $r) {
+ foreach ($hook_params['results'] as $r) {
$plugin_session_login_valid = true;
if ($r == FORGE_AUTH_AUTHORITATIVE_ACCEPT) {
$seen_yes = true;
@@ -642,7 +642,7 @@ function session_set() {
$seen_yes = false;
$seen_no = false;
- foreach ($params['results'] as $p => $r) {
+ foreach ($params['results'] as $r) {
if ($r == FORGE_AUTH_AUTHORITATIVE_ACCEPT) {
$seen_yes = true;
} elseif ($r == FORGE_AUTH_AUTHORITATIVE_REJECT) {
@@ -702,7 +702,7 @@ function session_set_for_authplugin($authpluginname) {
plugin_hook_by_reference('check_auth_session', $params);
$seen_yes = false;
- foreach ($params['results'] as $p => $r) {
+ foreach ($params['results'] as $r) {
if ($r == FORGE_AUTH_AUTHORITATIVE_ACCEPT) {
$seen_yes = true;
}
diff --git a/src/common/include/system/LDAP.class.php
b/src/common/include/system/LDAP.class.php
index d6f4ee8..4b54df8 100644
--- a/src/common/include/system/LDAP.class.php
+++ b/src/common/include/system/LDAP.class.php
@@ -486,8 +486,6 @@ class LDAP extends UNIX {
$entry['userPassword']='{crypt}x';
$entry['gidNumber']=$this->getUnixGID();
- $i=0; $i_cvs=0;
-
$ret_val=true;
if (!$this->gfLdapAdd($dn,$entry)) {
diff --git a/src/common/include/user_profile.php
b/src/common/include/user_profile.php
index 67636c1..2a8013d 100644
--- a/src/common/include/user_profile.php
+++ b/src/common/include/user_profile.php
@@ -5,7 +5,7 @@
* Copyright 1999-2001 (c) VA Linux Systems
* Copyright 2010, FusionForge Team
* Copyright (C) 2011-2012 Alain Peyrat - Alcatel-Lucent
- * Copyright 2018, Franck Villaume - TrivialDev
+ * Copyright 2018,2021, Franck Villaume - TrivialDev
* http://fusionforge.org
*
* This file is part of FusionForge. FusionForge is free software;
@@ -131,7 +131,6 @@ function user_personal_information($user, $compact = false,
$title = false) {
$subcells[][] = '<strong>'. relative_date($user->getAddDate()).
'</strong>';
$subtable .= $HTML->multiTableRow(array(), $subcells);
if ($compact) {
- $user_uri = util_make_url('/users/'. $user->getUnixName() .
'/');
$subcells = array();
$subcells[][] = '<small>'. _('URI')._(':') .'</small>';
$subcells[][] =
'<small>'.util_make_link_u($user->getUnixName(), $user->getID(),
util_make_url_u($user->getUnixName(), $user->getID())).'</small>';
diff --git a/src/common/include/utils.php b/src/common/include/utils.php
index ee96ae3..45f81ff 100644
--- a/src/common/include/utils.php
+++ b/src/common/include/utils.php
@@ -80,7 +80,7 @@ function is_utf8($str) {
*/
function util_strip_unprintable(&$data) {
if (is_array($data)) {
- foreach ($data as $key => &$value) {
+ foreach ($data as &$value) {
util_strip_unprintable($value);
}
} else {
@@ -421,7 +421,7 @@ function util_make_links($data = '') {
$lines = explode("\n", $data);
$newText = "";
- foreach ($lines as $key => $line) {
+ foreach ($lines as $line) {
// Do not scan lines if they already have hyperlinks.
// Avoid problem with text written with an WYSIWYG HTML editor.
if (eregi('<a ([^>]*)>.*</a>', $line, $linePart)) {
diff --git a/src/common/widget/WidgetLayoutManager.class.php
b/src/common/widget/WidgetLayoutManager.class.php
index a212604..29b02ee 100644
--- a/src/common/widget/WidgetLayoutManager.class.php
+++ b/src/common/widget/WidgetLayoutManager.class.php
@@ -501,7 +501,6 @@ class WidgetLayoutManager {
*/
function createLayoutForProjectFromArray($group_id, $layoutDescArr) {
if (isset($layoutDescArr['rows']) &&
is_array($layoutDescArr['rows'])) {
- $project = group_get_object($group_id);
db_query_params('DELETE FROM layouts_contents WHERE
owner_id = $1 AND owner_type = $2', array($group_id, self::OWNER_TYPE_GROUP));
db_query_params('DELETE FROM owner_layouts WHERE
owner_id = $1 AND owner_type = $2', array($group_id, self::OWNER_TYPE_GROUP));
$sql = "INSERT INTO layouts(name, description, scope)
VALUES ('custom', '', 'P')";
@@ -1061,7 +1060,7 @@ class WidgetLayoutManager {
$names = array();
$keyArray = getArrayFromRequest($key);
- foreach($keyArray as $k => $name) {
+ foreach($keyArray as $name) {
list($name, $id) = explode('-', $name);
$names[] = array($id, $name);
}
@@ -1102,7 +1101,6 @@ class WidgetLayoutManager {
//Update ranks
$rank = 0;
- $values = array();
foreach($names as $name) {
$sql = 'UPDATE layouts_contents SET
rank = $1 WHERE owner_type =$2 AND owner_id = $3 AND column_id = $4 AND name =
$5 AND content_id = $6';
db_query_params($sql, array($rank++,
$owner_type, $owner_id, $column_id, $name[1], $name[0]));
diff --git a/src/common/widget/Widget_HomeSponsoredHeadLines.class.php
b/src/common/widget/Widget_HomeSponsoredHeadLines.class.php
index a35d297..97674a9 100644
--- a/src/common/widget/Widget_HomeSponsoredHeadLines.class.php
+++ b/src/common/widget/Widget_HomeSponsoredHeadLines.class.php
@@ -1,6 +1,6 @@
<?php
/**
- * Copyright 2019, Franck Villaume - TrivialDev
+ * Copyright 2019,2021, Franck Villaume - TrivialDev
* This file is a part of Fusionforge.
*
* Fusionforge is free software; you can redistribute it and/or modify
@@ -46,7 +46,7 @@ class Widget_HomeSponsoredHeadLines extends Widget {
$old_date = time()-60*60*24*30;
$diaryFactory = new DiaryFactory();
if ($diaryFactory->hasSponsoredNotes($old_date)) {
- foreach ($diaryFactory->getSponsoredIDS($old_date) as
$key => $diarynoteid) {
+ foreach ($diaryFactory->getSponsoredIDS($old_date) as
$diarynoteid) {
$diaryNoteObject =
diarynote_get_object($diarynoteid);
$content .= $diaryNoteObject->getAbstract();
}
diff --git a/src/common/widget/Widget_MyArtifacts.class.php
b/src/common/widget/Widget_MyArtifacts.class.php
index cae4ae5..d4e979a 100644
--- a/src/common/widget/Widget_MyArtifacts.class.php
+++ b/src/common/widget/Widget_MyArtifacts.class.php
@@ -144,7 +144,6 @@ class Widget_MyArtifacts extends Widget {
$html_my_artifacts = '';
$html = '';
- $html_hdr = '';
$aid_old = 0;
$atid_old = 0;
@@ -153,9 +152,6 @@ class Widget_MyArtifacts extends Widget {
$group_name = '';
$tracker_name = '';
- $artifact_types = array();
- $allIds = array();
-
foreach ($list_trackers as $trackers_array) {
$atid = $trackers_array->getArtifactType()->getID();
$group_id =
$trackers_array->getArtifactType()->getGroup()->getID();
-----------------------------------------------------------------------
Summary of changes:
src/common/include/plugins_utils.php | 5 ++---
src/common/include/session.php | 8 ++++----
src/common/include/system/LDAP.class.php | 2 --
src/common/include/user_profile.php | 3 +--
src/common/include/utils.php | 4 ++--
src/common/widget/WidgetLayoutManager.class.php | 4 +---
src/common/widget/Widget_HomeSponsoredHeadLines.class.php | 4 ++--
src/common/widget/Widget_MyArtifacts.class.php | 4 ----
8 files changed, 12 insertions(+), 22 deletions(-)
hooks/post-receive
--
FusionForge
_______________________________________________
Fusionforge-commits mailing list
[email protected]
http://lists.fusionforge.org/cgi-bin/mailman/listinfo/fusionforge-commits
