This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "FusionForge".
The branch, master has been updated
via fb22e4f3391caba1662535fed90819d7d49020fb (commit)
from 2eee8b663e674076457fd171f3e68c691880df46 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://scm.fusionforge.org/anonscm/gitweb/?p=fusionforge/fusionforge.git;a=commitdiff;h=fb22e4f3391caba1662535fed90819d7d49020fb
commit fb22e4f3391caba1662535fed90819d7d49020fb
Author: Franck Villaume <franck.villa...@trivialdev.com>
Date: Thu May 13 09:08:35 2021 +0200
clean-up: remove unused vars
diff --git
a/src/common/widget/Widget_HomeDetailActivityMostActiveProjectWeek.class.php
b/src/common/widget/Widget_HomeDetailActivityMostActiveProjectWeek.class.php
index 0c37407..5544441 100644
--- a/src/common/widget/Widget_HomeDetailActivityMostActiveProjectWeek.class.php
+++ b/src/common/widget/Widget_HomeDetailActivityMostActiveProjectWeek.class.php
@@ -61,13 +61,11 @@ class Widget_HomeDetailActivityMostActiveProjectWeek
extends Widget {
}
if (count($activities) > 0) {
$date_format = _('%Y-%m-%d');
- $date_format_js = _('yy-mm-dd');
usort($activities, 'Activity::date_compare');
$displayTableTop = 0;
$last_day = 0;
$displayed_activities = false;
foreach ($activities as $activity) {
- $docmanerror = 0;
if
(!$ffactivity->check_perm_for_activity($activity, $this->cached_perms)) {
continue;
}
diff --git a/src/common/widget/Widget_HomeRss.class.php
b/src/common/widget/Widget_HomeRss.class.php
index e58bc7d..1fc486e 100644
--- a/src/common/widget/Widget_HomeRss.class.php
+++ b/src/common/widget/Widget_HomeRss.class.php
@@ -30,7 +30,6 @@ require_once 'Widget.class.php';
*/
class Widget_HomeRss extends Widget_Rss {
function __construct() {
- $request =& HTTPRequest::instance();
parent::__construct('homerss', 0,
WidgetLayoutManager::OWNER_TYPE_HOME);
}
diff --git a/src/common/widget/Widget_MyFollowers.class.php
b/src/common/widget/Widget_MyFollowers.class.php
index 73df1eb..bef7c2f 100644
--- a/src/common/widget/Widget_MyFollowers.class.php
+++ b/src/common/widget/Widget_MyFollowers.class.php
@@ -120,7 +120,6 @@ require_once $gfcommon.'include/MonitorElement.class.php';
usort($results,
'Activity::date_compare');
$displayTableTop = 0;
- $j = 0;
$last_day = 0;
foreach ($results as $arr) {
if
(!$ffactivity->check_perm_for_activity($arr, $cached_perms)) {
diff --git a/src/common/widget/Widget_MyLatestCommits.class.php
b/src/common/widget/Widget_MyLatestCommits.class.php
index ca4587c..354a61d 100644
--- a/src/common/widget/Widget_MyLatestCommits.class.php
+++ b/src/common/widget/Widget_MyLatestCommits.class.php
@@ -60,7 +60,6 @@ class Widget_MyLatestCommits extends Widget {
public function getContent() {
global $HTML;
$html = '';
- $hp = Codendi_HTMLPurifier::instance();
$user = UserManager::instance()->getCurrentUser();
$projects = $user->getGroups();
$global_nb_revisions = 0;
diff --git a/src/common/widget/Widget_MyMonitoredDocuments.class.php
b/src/common/widget/Widget_MyMonitoredDocuments.class.php
index 7f0e375..7b6f47e 100644
--- a/src/common/widget/Widget_MyMonitoredDocuments.class.php
+++ b/src/common/widget/Widget_MyMonitoredDocuments.class.php
@@ -90,7 +90,7 @@ class Widget_MyMonitoredDocuments extends Widget {
'class'
=> 'align-center');
$html .=
$HTML->multiTableRow(array(), $cells);
}
- foreach ($monitorElementDocIds
as $key => $monitorElementDocId) {
+ foreach ($monitorElementDocIds
as $monitorElementDocId) {
$documentObject =
document_get_object($monitorElementDocId, $distinctMonitorGroupId);
$cells = array();
$cells[] =
array(' - (f) '.util_make_link('/docman/?group_id='.$distinctMonitorGroupId.'&view=listfile&dirid='.$documentObject->getDocGroupID(),
stripslashes($documentObject->getFileName())), 'style' => 'width:99%');
diff --git a/src/common/widget/Widget_MyMonitoredForums.class.php
b/src/common/widget/Widget_MyMonitoredForums.class.php
index 2488ad2..90f5f2e 100644
--- a/src/common/widget/Widget_MyMonitoredForums.class.php
+++ b/src/common/widget/Widget_MyMonitoredForums.class.php
@@ -85,7 +85,7 @@ class Widget_MyMonitoredForums extends Widget {
$html_hdr =
$HTML->multiTableRow(array('class' => 'boxitem'), $cells);
$html = '';
if (!$hide_now) {
- foreach
($validMonitoredForumIds as $key => $validMonitoredForumId) {
+ foreach
($validMonitoredForumIds as $validMonitoredForumId) {
$forumObject =
forum_get_object($validMonitoredForumId);
$cells =
array();
$cells[] =
array(' - '.util_make_link('/forum/forum.php?forum_id='.$validMonitoredForumId,
$forumObject->getName()), 'style' => 'width:99%');
diff --git a/src/common/widget/Widget_MyMonitoredFp.class.php
b/src/common/widget/Widget_MyMonitoredFp.class.php
index ea8d5d3..7b8a116 100644
--- a/src/common/widget/Widget_MyMonitoredFp.class.php
+++ b/src/common/widget/Widget_MyMonitoredFp.class.php
@@ -80,7 +80,7 @@ class Widget_MyMonitoredFp extends Widget {
$html_hdr =
$HTML->multiTableRow(array('class' => 'boxitem'), $cells);
$html = '';
if (!$hide_now) {
- foreach
($validMonitoredPackageIds as $key => $validMonitoredPackageId) {
+ foreach
($validMonitoredPackageIds as $validMonitoredPackageId) {
$frsPackageObject = frspackage_get_object($validMonitoredPackageId);
$cells =
array();
$url =
'/frs/?group_id='.$validDistinctMonitorGroupId.'&package_id='.$validMonitoredPackageId.'&action=monitor&status=0&ajax=0';
diff --git a/src/common/widget/Widget_MySurveys.class.php
b/src/common/widget/Widget_MySurveys.class.php
index d47664e..5e54d7c 100644
--- a/src/common/widget/Widget_MySurveys.class.php
+++ b/src/common/widget/Widget_MySurveys.class.php
@@ -51,9 +51,8 @@ class Widget_MySurveys extends Widget {
foreach ($projects as $p) {
if ($p->usesSurvey()) {
$sf = new SurveyFactory($p);
- foreach ($sf->getSurveys() as $s) {
+ if (!empty($sf->getSurveysIds()) {
$tmp[] = $p;
- break;
}
}
}
@@ -64,7 +63,6 @@ class Widget_MySurveys extends Widget {
$html_my_surveys .= $HTML->warning_msg(_('There are no
surveys in your projects.'));
} else {
global $HTML;
- $request =& HTTPRequest::instance();
$html_my_surveys .= $HTML->listTableTop();
foreach ($projects as $project) {
$group_id = $project->getID();
diff --git a/src/common/widget/Widget_ProjectLatestFileReleases.class.php
b/src/common/widget/Widget_ProjectLatestFileReleases.class.php
index 612e6ab..bae4eaf 100644
--- a/src/common/widget/Widget_ProjectLatestFileReleases.class.php
+++ b/src/common/widget/Widget_ProjectLatestFileReleases.class.php
@@ -71,7 +71,7 @@ class Widget_ProjectLatestFileReleases extends Widget {
html_use_tablesorter();
$result .= $HTML->getJavascripts();
$result .= $HTML->listTableTop($titleArr, array(),
'sortable_widget_frs_listpackage full', 'sortable_frs', $classth);
- foreach ($frsrnrs as $key => $frsrnr) {
+ foreach ($frsrnrs as $frsrnr) {
$rel_date = $frsrnr->getReleaseDate();
$package_name = $frsrnr->FRSPackage->getName();
$package_release = $frsrnr->getName();
diff --git a/src/common/widget/Widget_ProjectLatestNews.class.php
b/src/common/widget/Widget_ProjectLatestNews.class.php
index 1a86c31..d1c9d09 100644
--- a/src/common/widget/Widget_ProjectLatestNews.class.php
+++ b/src/common/widget/Widget_ProjectLatestNews.class.php
@@ -52,16 +52,6 @@ class Widget_ProjectLatestNews extends Widget {
return true;
}
- function displayRss() {
- $owner = getStringFromRequest('owner');
- $group_id = (int)substr($owner, 1);
- require_once 'www/export/rss_utils.inc';
-//XXX the following function does not exist
-// rss_display_news($group_id, 10);
- echo 'Error! Use overridden getRssUrl method instead!';
- }
-
- /* replacement */
function getRssUrl($owner_id, $owner_type) {
if ($owner_type != 'g') {
return false;
diff --git a/src/common/widget/Widget_Rss.class.php
b/src/common/widget/Widget_Rss.class.php
index 9d4c410..2c4bc14 100644
--- a/src/common/widget/Widget_Rss.class.php
+++ b/src/common/widget/Widget_Rss.class.php
@@ -72,7 +72,7 @@ require_once 'Widget.class.php';
$items = array_slice($rss->get_items(), 0, $max_items);
if (count($items)) {
$content .= $HTML->listTableTop();
- foreach($items as $key => $item){
+ foreach($items as $item){
$content .= '<tr><td
style="width:99%">';
if ($image = $item->get_link(0,
'image')) {
//hack to display twitter avatar
diff --git a/src/common/widget/Widget_TrackerContent.class.php
b/src/common/widget/Widget_TrackerContent.class.php
index d5bc17a..f804b4a 100644
--- a/src/common/widget/Widget_TrackerContent.class.php
+++ b/src/common/widget/Widget_TrackerContent.class.php
@@ -116,8 +116,7 @@ class Widget_TrackerContent extends Widget {
.html_e('div', array('class' =>
'layout-manager-row-add'), '+');
if (count($this->layoutExtraFieldIDs) > 0) {
- foreach ($this->layoutExtraFieldIDs as $row_id =>
$column_id) {
- $cells = array();
+ foreach ($this->layoutExtraFieldIDs as $column_id) {
$content .= '<table class="layout-manager-row"
id="widget_layout_build">
<tr>
<td
class="layout-manager-column-add">+</td>';
@@ -376,7 +375,7 @@ EOS;
if (!forge_check_perm('tracker', $atid, 'submit') ||
($func == 'detail' && !session_loggedin())) {
$readonly = true;
}
- foreach ($this->layoutExtraFieldIDs as $row_id =>
$column_id) {
+ foreach ($this->layoutExtraFieldIDs as $column_id) {
$return .= $HTML->listTableTop();
$cells = array();
foreach ($column_id as $extrafieldID) {
diff --git a/src/common/widget/Widget_UserhomeActivity.class.php
b/src/common/widget/Widget_UserhomeActivity.class.php
index e702882..bedbd3e 100644
--- a/src/common/widget/Widget_UserhomeActivity.class.php
+++ b/src/common/widget/Widget_UserhomeActivity.class.php
@@ -2,7 +2,7 @@
/**
* Userhome Activity Widget Class
*
- * Copyright 2018, Franck Villaume - TrivialDev
+ * Copyright 2018,2021, Franck Villaume - TrivialDev
* http://fusionforge.org
*
* This file is a part of Fusionforge.
@@ -43,7 +43,6 @@ class Widget_UserhomeActivity extends Widget {
function getContent() {
global $HTML;
$groupsArr = array();
- $date_format = _('%Y-%m-%d');
$ids = array();
$texts = array();
@@ -108,11 +107,10 @@ class Widget_UserhomeActivity extends Widget {
echo $HTML->information(_('No Activity Found'));
} else {
$cached_perms = array();
-
+ $date_format = _('%Y-%m-%d');
usort($results, 'Activity::date_compare');
$displayTableTop = 0;
- $j = 0;
$last_day = 0;
foreach ($results as $arr) {
if (!$ffactivity->check_perm_for_activity($arr,
$cached_perms)) {
diff --git a/src/plugins/blocks/common/blocks_Widget_HomeSummary.class.php
b/src/plugins/blocks/common/blocks_Widget_HomeSummary.class.php
index d164526..850a285 100644
--- a/src/plugins/blocks/common/blocks_Widget_HomeSummary.class.php
+++ b/src/plugins/blocks/common/blocks_Widget_HomeSummary.class.php
@@ -90,7 +90,7 @@ class blocks_Widget_HomeSummary extends Widget {
if ($content) {
$sql = "UPDATE plugin_blocks SET title=$1,
content=$2 WHERE group_id =$3 AND id = $4";
- $res = db_query_params($sql, array($title,
$content, $this->group_id, getIntFromRequest('content_id')));
+ db_query_params($sql, array($title, $content,
$this->group_id, getIntFromRequest('content_id')));
$done = true;
}
}
@@ -107,11 +107,11 @@ class blocks_Widget_HomeSummary extends Widget {
$title = getStringFromRequest('title');
$content = getStringFromRequest('body');
$res = db_query_params('INSERT INTO plugin_blocks (group_id,
name, status, title, content)
- VALUES ($1, $2, 1, $3, $4)',
- array($this->owner_id, 'summary_block?', $title,
$content));
+ VALUES ($1, $2, 1, $3, $4)',
+ array($this->owner_id,
'summary_block?', $title, $content));
$content_id = db_insertid($res, 'plugin_blocks', 'id');
- $res = db_query_params('UPDATE plugin_blocks SET name=$1 WHERE
id=$2',
- array('summary_block'.$content_id, $content_id));
+ db_query_params('UPDATE plugin_blocks SET name=$1 WHERE id=$2',
+ array('summary_block'.$content_id,
$content_id));
return $content_id;
}
diff --git a/src/plugins/blocks/common/blocks_Widget_ProjectSummary.class.php
b/src/plugins/blocks/common/blocks_Widget_ProjectSummary.class.php
index 32d5168..4b8fb14 100644
--- a/src/plugins/blocks/common/blocks_Widget_ProjectSummary.class.php
+++ b/src/plugins/blocks/common/blocks_Widget_ProjectSummary.class.php
@@ -93,7 +93,7 @@ class blocks_Widget_ProjectSummary extends Widget {
if ($content) {
$sql = "UPDATE plugin_blocks SET title=$1,
content=$2 WHERE group_id =$3 AND id = $4";
- $res =
db_query_params($sql,array($title,$content,$this->group_id,
getIntFromRequest('content_id')));
+
db_query_params($sql,array($title,$content,$this->group_id,
getIntFromRequest('content_id')));
$done = true;
}
}
@@ -113,11 +113,11 @@ class blocks_Widget_ProjectSummary extends Widget {
$title = getStringFromRequest('title');
$content = getStringFromRequest('body');
$res = db_query_params('INSERT INTO plugin_blocks (group_id,
name, status, title, content)
- VALUES ($1, $2, 1, $3, $4)',
- array($this->owner_id, 'summary_block?', $title,
$content));
+ VALUES ($1, $2, 1, $3, $4)',
+ array($this->owner_id,
'summary_block?', $title, $content));
$content_id = db_insertid($res, 'plugin_blocks', 'id');
- $res = db_query_params('UPDATE plugin_blocks SET name=$1 WHERE
id=$2',
- array('summary_block'.$content_id, $content_id));
+ db_query_params('UPDATE plugin_blocks SET name=$1 WHERE id=$2',
+ array('summary_block'.$content_id,
$content_id));
return $content_id;
}
diff --git a/src/plugins/contribtracker/common/ContribTrackerPlugin.class.php
b/src/plugins/contribtracker/common/ContribTrackerPlugin.class.php
index e37e297..095cd0d 100644
--- a/src/plugins/contribtracker/common/ContribTrackerPlugin.class.php
+++ b/src/plugins/contribtracker/common/ContribTrackerPlugin.class.php
@@ -859,14 +859,14 @@ class ContribTrackerParticipation extends FFError {
$contrib_id = $this->getContribution()->getId();
db_begin();
- $res = db_query_params ('UPDATE
plugin_contribtracker_participation SET index = 0 WHERE participation_id = $1',
- array ($id));
- $res = db_query_params ('UPDATE
plugin_contribtracker_participation SET index = index+1 WHERE contrib_id = $1
AND index = $2',
- array ($contrib_id,
- $cur-1));
- $res = db_query_params ('UPDATE
plugin_contribtracker_participation SET index = $1 WHERE contrib_id = $2 AND
index = 0',
- array ($cur - 1,
- $contrib_id));
+ db_query_params ('UPDATE plugin_contribtracker_participation
SET index = 0 WHERE participation_id = $1',
+ array ($id));
+ db_query_params ('UPDATE plugin_contribtracker_participation
SET index = index+1 WHERE contrib_id = $1 AND index = $2',
+ array ($contrib_id,
+ $cur-1));
+ db_query_params ('UPDATE plugin_contribtracker_participation
SET index = $1 WHERE contrib_id = $2 AND index = 0',
+ array ($cur - 1,
+ $contrib_id));
db_commit();
}
@@ -886,14 +886,14 @@ class ContribTrackerParticipation extends FFError {
$contrib_id = $this->getContribution()->getId();
db_begin();
- $res = db_query_params ('UPDATE
plugin_contribtracker_participation SET index = 0 WHERE participation_id = $1',
- array ($id));
- $res = db_query_params ('UPDATE
plugin_contribtracker_participation SET index = index-1 WHERE contrib_id = $1
AND index = $2',
- array ($contrib_id,
- $cur+1));
- $res = db_query_params ('UPDATE
plugin_contribtracker_participation SET index = $1 WHERE contrib_id = $2 AND
index = 0',
- array ($cur + 1,
- $contrib_id));
+ db_query_params ('UPDATE plugin_contribtracker_participation
SET index = 0 WHERE participation_id = $1',
+ array ($id));
+ db_query_params ('UPDATE plugin_contribtracker_participation
SET index = index-1 WHERE contrib_id = $1 AND index = $2',
+ array ($contrib_id,
+ $cur+1));
+ db_query_params ('UPDATE plugin_contribtracker_participation
SET index = $1 WHERE contrib_id = $2 AND index = 0',
+ array ($cur + 1,
+ $contrib_id));
db_commit();
}
diff --git
a/src/plugins/globaldashboard/include/globalDashboard_Widget_MyProjects.php
b/src/plugins/globaldashboard/include/globalDashboard_Widget_MyProjects.php
index 0e5c6f6..059d3e2 100644
--- a/src/plugins/globaldashboard/include/globalDashboard_Widget_MyProjects.php
+++ b/src/plugins/globaldashboard/include/globalDashboard_Widget_MyProjects.php
@@ -80,7 +80,6 @@ class globalDashboard_Widget_MyProjects extends Widget {
$favicon_url =
$account['forge_account_domain'] . '/favicon.ico';
}
- $i = 0;
foreach ($remote_account_projs as $remote_proj)
{
$project_url =
$account['forge_account_domain'] . '/projects/'.
$remote_proj['unix_group_name'];
$cells = array();
diff --git a/src/plugins/globaldashboard/www/admin/manage_accounts.php
b/src/plugins/globaldashboard/www/admin/manage_accounts.php
index 4fd8766..c45331b 100644
--- a/src/plugins/globaldashboard/www/admin/manage_accounts.php
+++ b/src/plugins/globaldashboard/www/admin/manage_accounts.php
@@ -79,7 +79,6 @@ function listStoredRemoteAccounts($user_id) {
$html = '';
$tablearr = array(_("User Name"), _("Remote site"), _("User
account URL"), _("Actions"));
$html .= $HTML->listTableTop($tablearr);
- $i = 0;
foreach ($accounts as $account) {
$cells = array();
$cells[][] =
util_make_link($account['forge_account_uri'],
$account['forge_account_login_name'], array(), true);
diff --git a/src/plugins/globalsearch/common/globalsearch_Widget_Home.class.php
b/src/plugins/globalsearch/common/globalsearch_Widget_Home.class.php
index ae7822b..df2220b 100644
--- a/src/plugins/globalsearch/common/globalsearch_Widget_Home.class.php
+++ b/src/plugins/globalsearch/common/globalsearch_Widget_Home.class.php
@@ -25,7 +25,6 @@ class globalsearch_Widget_Home extends Widget {
var $content = '';
function __construct($owner_type, $owner_id) {
- $request =& HTTPRequest::instance();
if ($owner_type == WidgetLayoutManager::OWNER_TYPE_HOME) {
$this->widget_id = 'plugin_globalsearch_home';
$this->group_id = $owner_id;
diff --git a/src/plugins/headermenu/common/headermenuPlugin.class.php
b/src/plugins/headermenu/common/headermenuPlugin.class.php
index 3e8da48..bc2b0b1 100644
--- a/src/plugins/headermenu/common/headermenuPlugin.class.php
+++ b/src/plugins/headermenu/common/headermenuPlugin.class.php
@@ -450,7 +450,6 @@ in the main menu (outermenu) or in the project menu
(groupmenu).");
*/
function getGlobalAdminView() {
global $gfplugins;
- $user = session_get_user();
include
$gfplugins.$this->name.'/view/admin/viewGlobalConfiguration.php';
return true;
}
@@ -462,7 +461,6 @@ in the main menu (outermenu) or in the project menu
(groupmenu).");
*/
function getProjectAdminView() {
global $gfplugins;
- $user = session_get_user();
include
$gfplugins.$this->name.'/view/admin/viewProjectConfiguration.php';
return true;
}
diff --git a/src/plugins/hudson/include/HudsonJobWidget.class.php
b/src/plugins/hudson/include/HudsonJobWidget.class.php
index 21a47f3..1efc0ef 100644
--- a/src/plugins/hudson/include/HudsonJobWidget.class.php
+++ b/src/plugins/hudson/include/HudsonJobWidget.class.php
@@ -101,7 +101,7 @@ abstract class HudsonJobWidget extends HudsonWidget {
if (!existInRequest('cancel')) {
$job_id = getIntFromRequest($this->id);
$sql = "UPDATE plugin_hudson_widget SET job_id=$1 WHERE
owner_id = $2 AND owner_type = $3 AND id = $4";
- $res = db_query_params($sql, array($job_id,
$this->owner_id, $this->owner_type, getIntFromRequest('content_id')));
+ db_query_params($sql, array($job_id, $this->owner_id,
$this->owner_type, getIntFromRequest('content_id')));
}
return true;
}
diff --git a/src/plugins/hudson/include/HudsonTestResult.class.php
b/src/plugins/hudson/include/HudsonTestResult.class.php
index 4781be2..29b9825 100644
--- a/src/plugins/hudson/include/HudsonTestResult.class.php
+++ b/src/plugins/hudson/include/HudsonTestResult.class.php
@@ -41,13 +41,8 @@ class HudsonTestResult {
}
$this->hudson_test_result_url = $hudson_job_url .
"/lastBuild/testReport/api/xml/";
-
- $controler = $this->getHudsonControler();
-
$this->_setStreamContext();
-
$this->buildJobObject();
-
}
function getHudsonControler() {
diff --git a/src/plugins/hudson/include/HudsonWidget.class.php
b/src/plugins/hudson/include/HudsonWidget.class.php
index d4b96db..59bb6ad 100644
--- a/src/plugins/hudson/include/HudsonWidget.class.php
+++ b/src/plugins/hudson/include/HudsonWidget.class.php
@@ -1,6 +1,7 @@
<?php
/**
* Copyright (c) Xerox Corporation, Codendi Team, 2001-2009. All rights
reserved
+ * Copyright 2021, Franck Villaume - TrivialDev
*
* This file is a part of Fusionforge.
*
@@ -31,7 +32,7 @@ abstract class HudsonWidget extends Widget {
protected function getAvailableJobs() {
$jobs = array();
if ($this->owner_type == WidgetLayoutManager::OWNER_TYPE_USER) {
- $jobs = $this->getJobsByUser($user =
UserManager::instance()->getCurrentUser()->getId());
+ $jobs = $this->getJobsByUser(user_getid());
} else {
$jobs = $this->getJobsByGroup($this->group_id);
}
diff --git a/src/plugins/hudson/include/hudsonActions.class.php
b/src/plugins/hudson/include/hudsonActions.class.php
index 5116127..98268bd 100644
--- a/src/plugins/hudson/include/hudsonActions.class.php
+++ b/src/plugins/hudson/include/hudsonActions.class.php
@@ -1,6 +1,7 @@
<?php
/**
* Copyright (c) Xerox Corporation, Codendi Team, 2001-2009. All rights
reserved
+ * Copyright 2021, Franck Villaume - TrivialDev
*
* This file is a part of Fusionforge.
*
@@ -61,7 +62,6 @@ class hudsonActions extends Actions {
function updateJob() {
global $feedback, $error_msg;
$request =& HTTPRequest::instance();
- $group_id = $request->get('group_id');
$job_id = $request->get('job_id');
$new_job_url = $request->get('new_hudson_job_url');
$new_job_name = $request->get('new_hudson_job_name');
@@ -87,9 +87,7 @@ class hudsonActions extends Actions {
function deleteJob() {
global $feedback, $error_msg;
- $request =& HTTPRequest::instance();
- $group_id = $request->get('group_id');
- $job_id = $request->get('job_id');
+ $job_id = getIntFromRequest('job_id');
$job_dao = new
PluginHudsonJobDao(CodendiDataAccess::instance());
if ( ! $job_dao->deleteHudsonJob($job_id)) {
$error_msg .= _("Unable to delete Hudson job");
diff --git a/src/plugins/hudson/include/hudsonViews.class.php
b/src/plugins/hudson/include/hudsonViews.class.php
index 744663b..708b309 100644
--- a/src/plugins/hudson/include/hudsonViews.class.php
+++ b/src/plugins/hudson/include/hudsonViews.class.php
@@ -38,7 +38,6 @@ class hudsonViews extends Views {
}
function header() {
-
parent::header();
}
@@ -108,9 +107,7 @@ class hudsonViews extends Views {
function last_build() {
global $HTML;
- $request =& HTTPRequest::instance();
- $group_id = $request->get('group_id');
- $job_id = $request->get('job_id');
+ $job_id = getIntFromRequest('job_id');
$job_dao = new
PluginHudsonJobDao(CodendiDataAccess::instance());
$dar = $job_dao->searchByJobID($job_id);
@@ -164,11 +161,7 @@ class hudsonViews extends Views {
function last_test_result() {
global $HTML;
- $request =& HTTPRequest::instance();
- $group_id = $request->get('group_id');
- $job_id = $request->get('job_id');
- $user = UserManager::instance()->getCurrentUser();
-
+ $job_id = getIntFromRequest('job_id');
$job_dao = new
PluginHudsonJobDao(CodendiDataAccess::instance());
$dar = $job_dao->searchByJobID($job_id);
if ($dar->valid()) {
@@ -182,10 +175,7 @@ class hudsonViews extends Views {
function test_trend() {
global $HTML;
$request =& HTTPRequest::instance();
- $group_id = $request->get('group_id');
- $job_id = $request->get('job_id');
- $user = UserManager::instance()->getCurrentUser();
-
+ $job_id = getIntFromRequest('job_id');
$job_dao = new
PluginHudsonJobDao(CodendiDataAccess::instance());
$dar = $job_dao->searchByJobID($job_id);
if ($dar->valid()) {
-----------------------------------------------------------------------
Summary of changes:
...meDetailActivityMostActiveProjectWeek.class.php | 2 --
src/common/widget/Widget_HomeRss.class.php | 1 -
src/common/widget/Widget_MyFollowers.class.php | 1 -
src/common/widget/Widget_MyLatestCommits.class.php | 1 -
.../widget/Widget_MyMonitoredDocuments.class.php | 2 +-
.../widget/Widget_MyMonitoredForums.class.php | 2 +-
src/common/widget/Widget_MyMonitoredFp.class.php | 2 +-
src/common/widget/Widget_MySurveys.class.php | 4 +--
.../Widget_ProjectLatestFileReleases.class.php | 2 +-
.../widget/Widget_ProjectLatestNews.class.php | 10 -------
src/common/widget/Widget_Rss.class.php | 2 +-
src/common/widget/Widget_TrackerContent.class.php | 5 ++--
.../widget/Widget_UserhomeActivity.class.php | 6 ++--
.../common/blocks_Widget_HomeSummary.class.php | 10 +++----
.../common/blocks_Widget_ProjectSummary.class.php | 10 +++----
.../common/ContribTrackerPlugin.class.php | 32 +++++++++++-----------
.../include/globalDashboard_Widget_MyProjects.php | 1 -
.../globaldashboard/www/admin/manage_accounts.php | 1 -
.../common/globalsearch_Widget_Home.class.php | 1 -
.../headermenu/common/headermenuPlugin.class.php | 2 --
.../hudson/include/HudsonJobWidget.class.php | 2 +-
.../hudson/include/HudsonTestResult.class.php | 5 ----
src/plugins/hudson/include/HudsonWidget.class.php | 3 +-
src/plugins/hudson/include/hudsonActions.class.php | 6 ++--
src/plugins/hudson/include/hudsonViews.class.php | 16 ++---------
25 files changed, 44 insertions(+), 85 deletions(-)
hooks/post-receive
--
FusionForge
_______________________________________________
Fusionforge-commits mailing list
Fusionforge-commits@lists.fusionforge.org
http://lists.fusionforge.org/cgi-bin/mailman/listinfo/fusionforge-commits
