Hi Matthieu,

Le 26/10/2015 15:42, Matthieu Imbert a écrit :
On 10/22/2015 11:30 AM, Matthieu Imbert wrote:
We have a recurring little issue on some git projects of our
fusionforge instance: in the "Repository History" panel of the scm
tab, the names of the contributors of the projects (with the counts of
"Adds" and "Updates") are sometimes wrong. #1 Some users may have less
contributions counted than the reality, #2 Some users may not be
listed at all, #3 some users are unduly attributed some commits.

A big part of these problems were solved by commits
1da92a5bb4f80f42df5d4cc03435d9641a771ee3 and
1a6dc7231c562105613e42a9eb2127878b9e5bf0.

There are still some cases where there are inaccuracies, and this is
particularly annoying in case #3 since project members are then
surprised to see an unknown commiter listed.

This is caused by the fact that the name/email of the commiter, as
recorded by git, is free text and may not match the Real Name / email
of the forge user. The code which tries to match git commiters to
forge users is located in function gatherStats, in
src/plugins/scmgit/common/GitPlugin.class.php

One of our users (Emmanuel Thomé) suggested a very good solution: allow using the .mailmap option of git: each repo may add a .mailmap at the root of its tree, which allow mapping user names and emails to canonical ones. See section MAPPING AUTHORS in git-shortlog(1) manpage.

Attached patch allows using the .mailmap if available, and has no effect otherwise.

What do you think about including it in branch 6.0?

Committed :)

AFAIU this is basically allowing a user to register several e-mail for his accounts, except that there is no verification (comparing with other forges, GitHub verifies, GitLab doesn't).

- Sylvain


_______________________________________________
Fusionforge-general mailing list
Fusionforge-general@lists.fusionforge.org
http://lists.fusionforge.org/cgi-bin/mailman/listinfo/fusionforge-general

Reply via email to