On 8/28/07, Viktor Griph <[EMAIL PROTECTED]> wrote:
> On Tue, 28 Aug 2007, Dominik Vogt wrote:
>
> > On Tue, Aug 28, 2007 at 02:55:26PM +0100, seventh guardian wrote:
> >> On 8/28/07, seventh guardian <[EMAIL PROTECTED]> wrote:
> >> (...)
> >> cc1: warnings being treated as errors
> >> Flocale.c: In function 'FlocaleGetFftFont':
> >> Flocale.c:1079: warning: assignment discards qualifiers from pointer 
> >> target type
> >
> > I guess we have to remove the "const" then.  That's better than
> > casting it away every time.
>
> There are so many places in the code where one would want to use
> const strings, but it's not possible because there are other functions
> which don't use const.
>
> It would be a good thing to add some const where possible in order to make
> it possible to wrtie new code using const specifiers. Having correctly
> specifired const where functiond don't change on the input is a good thing
> for code readablity. I'm not sure exactly where the deadend is for
> changing stuff to const, but I believe it's somewhere in the parsing
> functions.

I'd also prefer changing to const wherever possible. Maybe after the release..

Dominik I don't like your weird solution :P

> But right now removing the const is best.

Agreed. For now I'll remove the const, but will leave a "TODO" comment.

Cheers,
  Renato

Reply via email to