On 9/1/07, Dominik Vogt <[EMAIL PROTECTED]> wrote:
> This warning "fix" introduced a real bug to FvwmButtons:
>
> -    if(num<old || old+32<old)
> +    if(num<old || old>(old+=32))
>                             ^
>
> Since this is part of 2.5.22 we've got to release 2.5.23
> immediately.  I'll take care of this.

Hum I thought it was safe, since "old" wasn't used anymore, and I
didn't want to add a new variable.. I guess I screwed up :/

For those who didn't get the warning, gcc-4.2 complained that it
assumed X+c > X to be always true, even with signed integer overflow.

Cheers,
  Renato

Reply via email to