Hi, Am I missing something or are you forgetting to update a ->next pointer somewhere? (It looks like you are leaving the previous next pointing to the freed structure.)
The old code, while uglier, I think handled that case. Adam Viktor Griph wrote: > On Sat, 9 Feb 2008, Adam Goode wrote: > >> Hi, >> >> FVWM segfaults under certain conditions described here: >> https://bugzilla.redhat.com/show_bug.cgi?id=382321 and especially here: >> https://bugzilla.redhat.com/show_bug.cgi?id=382321#c12 >> >> This happens even in the CVS version. >> >> It is a problem with an error case that calls module_list_remove when >> module_list is empty. >> >> A patch is here: >> >> http://cvs.fedoraproject.org/viewcvs/*checkout*/devel/fvwm/fvwm-2.5.24-module_list_remove.patch >> >> > > I've commited a different fix for this to the CVS. (I changed to code to > make no special treatment of the first module in the list.) > > /Viktor
signature.asc
Description: OpenPGP digital signature
