On Tue, Feb 12, 2008 at 02:16:36PM +0000, seventh guardian wrote: > On Feb 10, 2008 12:20 AM, seventh guardian <[EMAIL PROTECTED]> wrote: > > On Feb 9, 2008 11:39 PM, Dominik Vogt <[EMAIL PROTECTED]> wrote: > (...) > > > > The first problem we have is that the user needs to manually specify > > > > the visual id, which changes with the xorg setup. Most users would > > > > expect some form of automatic configuration, so here are the > > > > alternatives: > > > > 1) Leave it as is (not user friendly nor portable, bad idea IMHO) > > > > 2) Provide a command line switch for argb, like "fvwm --argb" > > > > 3) Detect if the composite extension is present, and activate the argb > > > > visuals if it is. > > > > 4) Provide a config file option for argb visuals. > (...) > > I've selected option 2, as it seems to be both conservative and easy to use. > > Patch for this attached. I'm tempted to commit this in "disabled by > default" #ifdef guards. It makes it easier for people to test the > changes by enabling the appropriate #define, yet it stays away from > the normal user.
Please do not commit check in ifdefs. You can mark the feature as "experimental" in the NEWS and manpage. Conditional compilation always causes trouble. Ciao Dominik ^_^ ^_^ -- Dominik Vogt
