On Fri, Aug 08, 2008 at 07:12:23AM -0500, fvwm-workers wrote: > CVSROOT: /home/cvs/fvwm > Module name: fvwm > Changes by: domivogt 08/08/08 07:12:23 > > Modified files: > . : ChangeLog > fvwm : ewmh_events.c > > Log message: > * Fixed compile error caused by logic error in ewmh_events.
The code was something like this: if (x & 1 == 0) ... which shuould really be if ((x & 1) == 0) ... because the compiler exaluates "1 == 0" first (result is 0), and then "x & 0" which is always 0. Viktor, if you *always* compile with make CFLAGS="-g -O2 -Wall -Wpointer-arith -fno-strict-aliasing -Werror" gcc will catch these errors for you because is insists on using parentheses in this case. Ciao Dominik ^_^ ^_^ -- Dominik Vogt
