On Sun, 25 Jan 2009, Thomas Adam wrote:
2009/1/22 Thomas Adam <[email protected]>:
I shall come up with something soon enough for review. Should be fun.
And so I have. I've made "MapCommand" accept anything (i.e., a valid
FVWM builtin, or a defined function) and in so doing have done the
following:
* Deprecate StartsRaised in favour of: Style foo MapCommand Raise
* Deprecate StartsLowered in favout of: Style foo MapCommand Lower
* Deprecate StartIconic in favour of: Style foo MapCommand Iconify
* Deprecate StartNormal in favour of: Style foo MapCommand Iconify off
* Deprecate StartShaded in favour of: Style foo MapCommand WindowShade dir
What about the Layer, StaysOnTop, StaysPut and StaysOnBottom styles?
I think that the way they work now is just confusing, since they can't be
used to chage the layer of a mapped window. I think that they either
should be mapped to the Layer command when chaning the style of active
windows, or be deprecated in favor of use of the Layer command with the
MapCommand style option.
Perhaps the only "damaging" change is in deprecating the
aforementioned options, I really have done just that -- i.e., there
really is no further support for them other than a standard
deprecation message should FVWM find one of these style commands. I
realise this breaks any chance of backwards compatability, but it
allows for removing code no longer needed if this MapCommand is
accepted.
Not having checked the patch yet, one thing strikes me which can be
troublesome: What about windows created by programs grabbing the pointer.
Would forcing the use of complex functions for things that used to be
doable without them make some configurations impossible to recreate?
/Viktor
