On Sat, Feb 07, 2009 at 08:27:54PM +0000, Thomas Adam wrote: > 2009/2/7 Dominik Vogt <[email protected]>: > > On Fri, Feb 06, 2009 at 09:35:30AM +0000, Thomas Adam wrote: > >> 2009/2/6 Dominik Vogt <[email protected]>: > >> > On Thu, Feb 05, 2009 at 10:55:16PM +0000, Thomas Adam wrote: > >> >> 2009/1/26 Thomas Adam <[email protected]>: > >> > I was planning to look into the patch on saturday evening (GMT) or > >> > maybe earlier. > >> > >> Ah, OK. Please don't think I'm forcing your hand on this, I just > >> never know how much time to give between pauses before I give a gentle > >> reminder that I haven't completely abandoned an idea. :) > > > > Neither have I. I have attached a much smaller version of the > > patch that removes all code that replaces other styles and fixes a > > couple of small problems: > > > > * Don't look up the style in events.c again but pass the string > > back from AddWindow(). As a side effect, the command is only > > executed when the window is mapped initially, not when it's > > mapped because of deiconification. Therefore I renamed the > > style to InitialMapCommand (which may or may not be a good > > idea). > > Ok, that looks fine to me. Note "initialMapCommand" is also fine with > me, as it really does just that. Anything else would be shed-painting > if you ask me, and I have to deal with that enough at work. :) > > > * Call execute_function_override_window() with the proper > > execution context. > > Please see the attached patch which also adds the relevant > documentation to go with this new style. I've not bothered to update > AUTHORS or anything like that, you've thankfully saved me the trouble. > > I recommend you consider comitting this to CVS, and perhaps release a > new unstable version? I think there's enough material in there now to > warrant that.
Applied. Try to remind me of the new release next week. Ciao Dominik ^_^ ^_^ -- Dominik Vogt
