On Sun, Feb 08, 2009 at 05:55:51PM +0000, Thomas Adam wrote:
> 2009/2/8 Dominik Vogt <[email protected]>:
[sniiip]
> >> + int modmask = mask;
> >
> > Please don't declare variables in the middle of a block. This
> > does not compile with oplder compilers.
>
> I didn't quite understand what you meant by this -- the declaration
> wasn't in a block,
All code is in blocks. Don't forget the curly braces that
delimit the function body :-)
> it was just after the function had been declared.
> I've tried to change it, but if it's still wrong, do say and I'll
> correct it again.
In C89 you can't have
{
declaration;
statement;
declaration;
}
You have to put all the declarations at the beginning of the
block, i.e.:
Wrong (does not compile):
void foo(void)
{
int x;
memset(&x, 0, sizeof(x);
int y;
}
Right:
void foo(void)
{
int x;
int y;
memset(&x, 0, sizeof(x);
}
More comments later when I've got time to look at the new patch.
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt
