Hi -- 2009/7/1 Manoj Srivastava <[email protected]>: > The menu lines in the sample config file are missing the trailing % > signs for icon images. This patch fixes them. > > Signed-off-by: Manoj Srivastava <[email protected]> > --- > sample.fvwmrc/system.fvwm2rc-sample-95 | 40 > ++++++++++++++++---------------- > 1 files changed, 20 insertions(+), 20 deletions(-)
Please can you create a new patch file against the CVS sources please? Whilst this file hasn't changed in ages, this patch conflits a lot -- to the extent where I don't want to have to fix this manually, sorry. Do you have any Debian-specific changes to this file before the patch was created? That being the case, that might explain why it won't apply cleanly here. In which case, you'll have to ensure when you generate the new patch that it's against vanilla sources. :) To the rest of fvwm-workers: the only reason I am interested in fixing this is because Debian (and I assume Ubuntu) don't ship the default system.fvwm2rc file most package maintainers leave in place for FVWM to read because most people consider the default "ugly" -- instead, the user is forces to use FvwmForm-Setup to create a user-based config which is arguarbly just as "ugly". Hence this patch will eventually address this issue for some Debian users, hopefully. These sorts of issues come up from time to time, and need addressing, either before or after 2.5 goes stable, I personally consider this a usability bug that needs addressing sooner, rather than later -- as many people fail to realise the potential of FVWM as all the damn default configs are created from users from 1993 - 1995 onwards in mind. I don't want to get into this now --- we have fvwm-themes as a basis, as well as fvwm-crystal, and even others [1] but it's food for thought. :) -- Thomas Adam [1] http://www.mail-archive.com/[email protected]/msg14579.html
