On Wed, Jan 13, 2010 at 01:41:21PM -0600, Rich Coe wrote:
> This patch implements a message to modules when an application 
> changes layers.  It is one property of a window that isn't broadcast
> when modified.
> 
> Please apply this patch.
> (diff from recent cvs checkout)

There was a very similar patch to this for use also with FvwmEvent, which
you probably didn't even think of when writing this?   In that case, I
really don't want yet another module parameter to the protocol when
M_CONFIGURE_WINDOW would suffice -- but I realise your patch isn't
addressing this, but if we do decide to broadcast such messages, then it
would do.

Also, your patch is missing a little justification for this, ChangeLog
entries, references in NEWS and optionally AUTHORS.  Please see the relevant
documentation on submitting patches.

-- Thomas Adam

-- 
"It was the cruelest game I've ever played and it's played inside my head."
-- "Hush The Warmth", Gorky's Zygotic Mynci.

Reply via email to