On Wed, Apr 07, 2010 at 07:32:34AM +0100, Thomas Adam wrote:
> On Wed, Apr 07, 2010 at 02:47:45PM +0900, Kan Sasaki wrote:
> > Dear all,
> > 
> > Some obsolete functions in libpng was removed since libpng-1.4.0. This
> > change causes compilation error.
> 
> Thanks.  libpng-1.4.0 is still really new, so it's not surprising this has
> only come up.
> 
> I am not in favour of using #ifdefs in this way.  Doing this sort of thing
> at configure time is much more appropriate.  But I get the idea with your
> patch.

Well, I applied it anyway.

In the future, we really want to be doing this via foo.h.in and let
configure sort this out for us.  We can do it via AC_CONFIG_FILES and
AC_SUBST -- but such a change would mean a lot of work/changes to how we
derive currently static code.

So it's going my TODO list post FVWM-2.6.

For now, it's fudged as per your patch in libs/Fpng.h

Thanks.

-- Thomas Adam

-- 
"It was the cruelest game I've ever played and it's played inside my head."
-- "Hush The Warmth", Gorky's Zygotic Mynci.

Reply via email to