On Mon, Apr 18, 2011 at 12:29:43AM +0400, Sergey Vlasov wrote:
> On Sat, 16 Apr 2011 15:24:41 -0500 [email protected] wrote:
>
> > Fixes to fvwm-menu-desktop
> >
> > * Make XML::Parser a runtime check, as it's a non-core module.
>
> This replaces a cryptic error "Can't locate XML/Parser.pm in @INC..."
> with a nicer error message; unfortunately, it also complicates
> packaging of such scripts. At least rpm in most distributions can
> automatically convert "use" statements in perl scripts to package
> dependencies, so that all required perl modules would be installed
> automatically. Wrapping such "use" statements in "eval" breaks this
> automatic extraction of dependencies; then the packager has two
> options:
>
> - patch the code to replace "eval" with bare "use" again;
> - manually add the dependency to the spec file.
>
> (And the packager needs to notice such dependency in the first place,
> which would in general require reviewing of changes between versions -
> if the packager had the XML::Parser module already installed, he would
> not notice any breakage in his system when testing.)
That's the packager's problem. At present (and for a long time to come most
likely), XML::Parser is the only external library fvwm-menu-desktop needs.
I can't speak for other distributions, but if RH have a nice way of
converting use statements to dependencies, great.
But I won't sacrifice easy of RH package management for other systems where
out-of-the-box, there's still a chance XML::Parser isn't present.
So -- option 2 for you it is then -- add it in manually, and I promise to
inform all willing downstream RH maintainers if/when newer dependencies away
from the Perl core for which we have the minimum use 5.xxx string, becomes
apparent.
-- Thomas Adam
--
"Deep in my heart I wish I was wrong. But deep in my heart I know I am
not." -- Morrissey ("Girl Least Likely To" -- off of Viva Hate.)
